Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8591026: Roll DOM APIs forward on IDL & update Frog DOM (Closed)

Created:
9 years, 1 month ago by vsm
Modified:
9 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Roll DOM APIs forward on IDL & update Frog DOM Note, the frog DOM is generated via: > ../tools/copy_dart.py frog frog_dom.dart to keep it a single file. I'll experiment to get rid of this level of indirection in a later CL. Committed: https://code.google.com/p/dart/source/detail?r=1644

Patch Set 1 #

Patch Set 2 : Fix for Frog #

Patch Set 3 : Patch release file #

Patch Set 4 : Switch frog to pull dart/client/dom/frog/frog_dom.dart. #

Total comments: 2

Patch Set 5 : Merge #

Patch Set 6 : Address siggi's comment #

Total comments: 1

Patch Set 7 : Change window and document to getters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -6726 lines) Patch
A + client/dom/frog/frog_dom.dart View 1 2 3 4 5 6 72 chunks +237 lines, -131 lines 0 comments Download
A + client/dom/frog/frog_dom.js View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M client/dom/frog_dom.dart View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M client/dom/frog_dom.js View 1 2 3 4 5 1 chunk +3 lines, -5 lines 0 comments Download
M client/dom/generated/monkey_dom.js View 1 2 3 4 5 6 3 chunks +4 lines, -2 lines 0 comments Download
M client/dom/generated/monkey_dom_externs.js View 1 2 3 4 5 6 4 chunks +4 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/CanvasRenderingContext2D.dart View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/HTMLSelectElement.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/CanvasRenderingContext2D.dart View 1 2 3 4 5 6 4 chunks +8 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/HTMLSelectElement.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/wrapping/_CanvasRenderingContext2DWrappingImplementation.dart View 1 2 3 4 5 6 4 chunks +12 lines, -42 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLSelectElementWrappingImplementation.dart View 1 chunk +13 lines, -4 lines 0 comments Download
M client/dom/generated/wrapping_dom.js View 1 2 3 4 5 6 3 chunks +42 lines, -2 lines 0 comments Download
M client/dom/generated/wrapping_dom_externs.js View 1 2 3 4 5 6 4 chunks +2 lines, -2 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M client/dom/scripts/template_frog_dom.darttemplate View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M frog/frogsh View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D frog/lib/dom/dom.dart View 1 2 3 1 chunk +0 lines, -6514 lines 0 comments Download
D frog/lib/dom/frog_dom.js View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M frog/reader.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vsm
9 years, 1 month ago (2011-11-17 23:52:16 UTC) #1
Siggi Cherem (dart-lang)
http://codereview.chromium.org/8591026/diff/5001/client/dom/frog/frog_dom.js File client/dom/frog/frog_dom.js (right): http://codereview.chromium.org/8591026/diff/5001/client/dom/frog/frog_dom.js#newcode8 client/dom/frog/frog_dom.js:8: return this.constructor.name; is this part of the change on ...
9 years, 1 month ago (2011-11-18 00:15:45 UTC) #2
vsm
http://codereview.chromium.org/8591026/diff/5001/client/dom/frog/frog_dom.js File client/dom/frog/frog_dom.js (right): http://codereview.chromium.org/8591026/diff/5001/client/dom/frog/frog_dom.js#newcode8 client/dom/frog/frog_dom.js:8: return this.constructor.name; No - thanks for the catch. Will ...
9 years, 1 month ago (2011-11-18 00:22:01 UTC) #3
vsm
Fixed and tested for siggi's last comment. PTAL.
9 years, 1 month ago (2011-11-18 00:50:38 UTC) #4
Siggi Cherem (dart-lang)
lgtm
9 years, 1 month ago (2011-11-18 01:28:42 UTC) #5
sra1
9 years, 1 month ago (2011-11-18 01:37:33 UTC) #6 
lgtm

http://codereview.chromium.org/8591026/diff/9001/client/dom/scripts/template_...
File client/dom/scripts/template_frog_dom.darttemplate (right):

http://codereview.chromium.org/8591026/diff/9001/client/dom/scripts/template_...
client/dom/scripts/template_frog_dom.darttemplate:18: HTMLDocument document;
If you don't intend for it to be writable, add a TODO referencing the bug, and
reference this TODO in the bug

Powered by Google App Engine
This is Rietveld 408576698