client/dom/frog_dom.js - Issue 8591026: Roll DOM APIs forward on IDL & update Frog DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/dom/frog_dom.js

Issue 8591026: Roll DOM APIs forward on IDL & update Frog DOM (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change window and document to getters Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/dom/frog_dom.js

diff --git a/client/dom/frog_dom.js b/client/dom/frog_dom.js

index 45984d4a0f35c3ec9f5d02e4be71a93e63dff3c7..a794918b8255a2ce3fb5317f58398462db94052c 100644

--- a/client/dom/frog_dom.js

+++ b/client/dom/frog_dom.js

@@ -2,8 +2,6 @@

// BSD-style license that can be found in the LICENSE file.

-// TODO(vsm): Don't monkey patch Object and make this work on

-// non-chrome browsers.

-Object.prototype.get$typeName = function() {

- return this.constructor.name;

+// TODO(jmesserly): we need to find a way to avoid conflicts with other

+// generated "typeName" fields. Ideally we wouldn't be patching 'Object' here.

+Object.prototype.get$typeName = Object.prototype.$typeNameOf;

« no previous file with comments | « client/dom/frog_dom.dart ('k') | client/dom/generated/monkey_dom.js » ('j') | no next file with comments »