Issue 8588002: Better tracing of deoptimization (added a reason id and printing of source). Fix a bug with exces...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8588002: Better tracing of deoptimization (added a reason id and printing of source). Fix a bug with exces... (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Better tracing of deoptimization (added a reason id and printing of source). Fix a bug with excessive deoptimization for null receiver -- caused by (null).toString(). Committed: https://code.google.com/p/dart/source/detail?r=1593

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+238 lines, -79 lines)			Patch
M	runtime/vm/code_generator.h	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View		3 chunks	+16 lines, -3 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.h	View		3 chunks	+19 lines, -6 lines	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1	29 chunks	+173 lines, -70 lines	1 comment	Download
M	runtime/vm/stub_code_ia32.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

regis

9 years, 1 month ago (2011-11-16 23:06:45 UTC) #2

LGTM

http://codereview.chromium.org/8588002/diff/2003/runtime/vm/opt_code_generato...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/8588002/diff/2003/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:2346: // re-optimize this optiumized
function.
optiumized?
opium-ized?

Expand Messages | Collapse Messages