Better tracing of deoptimization (added a reason id and printing of source). Fix a bug with exces...

runtime/vm/code_generator.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
@@ skipping 847 matching lines @@
   }
 }
 
 
 // The top Dart frame belongs to the optimized method that needs to be
 // deoptimized. The pc of the Dart frame points to the deoptimization point.
 // Find the node id of the deoptimization point and find the continuation
 // pc in the unoptimized code.
 // Since both unoptimized and optimized code have the same layout, we need only
 // to patch the pc of the Dart frame and to disable/enable appropriate code.
-DEFINE_RUNTIME_ENTRY(Deoptimize, 0) {
+DEFINE_RUNTIME_ENTRY(Deoptimize, 1) {
   ASSERT(arguments.Count() == kDeoptimizeRuntimeEntry.argument_count());
+  const Smi& deoptimization_reason_id = Smi::CheckedHandle(arguments.At(0));
   DartFrameIterator iterator;
   DartFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
   CodeIndexTable* ci_table = isolate->code_index_table();
   const Code& optimized_code =
       Code::Handle(ci_table->LookupCode(caller_frame->pc()));
   const Function& function = Function::Handle(optimized_code.function());
   ASSERT(!function.IsNull());
   const Code& unoptimized_code = Code::Handle(function.unoptimized_code());
   ASSERT(!optimized_code.IsNull() && optimized_code.is_optimized());
   ASSERT(!unoptimized_code.IsNull() && !unoptimized_code.is_optimized());
   const PcDescriptors& descriptors =
       PcDescriptors::Handle(optimized_code.pc_descriptors());
   ASSERT(!descriptors.IsNull());
   // Locate node id at deoptimization point inside optimized code.
   intptr_t deopt_node_id = AstNode::kNoId;
+  intptr_t deopt_token_index = 0;
   for (int i = 0; i < descriptors.Length(); i++) {
     if (static_cast<uword>(descriptors.PC(i)) == caller_frame->pc()) {
       deopt_node_id = descriptors.NodeId(i);
+      deopt_token_index = descriptors.TokenIndex(i);
       break;
     }
   }
   ASSERT(deopt_node_id != AstNode::kNoId);
   uword continue_at_pc =
       unoptimized_code.GetDeoptPcAtNodeId(deopt_node_id);
   ASSERT(continue_at_pc != 0);
   if (FLAG_trace_deopt) {
-    OS::Print("Deoptimizing at pc 0x%x id %d '%s' -> continue at 0x%x \n",
-        caller_frame->pc(), deopt_node_id, function.ToFullyQualifiedCString(),
+    OS::Print("Deoptimizing (reason %d) at pc 0x%x id %d '%s' "
+        "-> continue at 0x%x \n",
+        deoptimization_reason_id.Value(),
+        caller_frame->pc(),
+        deopt_node_id,
+        function.ToFullyQualifiedCString(),
         continue_at_pc);
+    const Class& cls = Class::Handle(function.owner());
+    const Script& script = Script::Handle(cls.script());
+    intptr_t line, column;
+    script.GetTokenLocation(deopt_token_index, &line, &column);
+    OS::Print("  Line: %d Column: %d ", line, column);
+    OS::Print(">>  %s\n", String::Handle(script.GetLine(line)).ToCString());
   }
   caller_frame->set_pc(continue_at_pc);
   // Clear invocation counter so that the function gets optimized after
   // types/classes have been collected.
   function.set_invocation_counter(0);
   function.set_deoptimization_counter(function.deoptimization_counter() + 1);
 
   // We have to skip the following otherwise the compiler will complain
   // when it attempts to install unoptimized code into a function that
   // was already deoptimized.
@@ skipping 84 matching lines @@
       }
     }
   }
   // The cache is null terminated, therefore the loop above should never
   // terminate by itself.
   UNREACHABLE();
   return Code::null();
 }
 
 }  // namespace dart