Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 8569017: Generate constructors for frog DOM (Closed)

Created:
9 years, 1 month ago by vsm
Modified:
9 years, 1 month ago
Reviewers:
sra, sra1, Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Generate constructors for frog DOM Note, this overlaps with the other CL (http://codereview.chromium.org/8595020/) as the underlying IDL has changed. Stephen: If this looks good, I can autogen the wrapper templates as well. Committed: https://code.google.com/p/dart/source/detail?r=1691

Patch Set 1 #

Patch Set 2 : Refresh the single file version #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -19 lines) Patch
M client/dom/frog/frog_dom.dart View 1 6 chunks +10 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/CanvasRenderingContext2D.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/FileReader.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/WebKitCSSMatrix.dart View 1 chunk +2 lines, -0 lines 1 comment Download
M client/dom/generated/src/frog/WebKitPoint.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/XMLHttpRequest.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/CanvasRenderingContext2D.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_CanvasRenderingContext2DWrappingImplementation.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 3 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vsm
9 years, 1 month ago (2011-11-19 00:09:16 UTC) #1
sra1
9 years, 1 month ago (2011-11-19 01:18:50 UTC) #2
http://codereview.chromium.org/8569017/diff/2001/client/dom/generated/src/fro...
File client/dom/generated/src/frog/WebKitCSSMatrix.dart (right):

http://codereview.chromium.org/8569017/diff/2001/client/dom/generated/src/fro...
client/dom/generated/src/frog/WebKitCSSMatrix.dart:3: WebKitCSSMatrix([String
spec]) native;
It is not clear how this can be made to work on non-webkit browsers (where the
type is CSSMatrix http://www.w3.org/TR/css3-3d-transforms/#cssmatrix-interface)

I think the factory provider syntax at least allows delegation to some code that
can create a CSSMatrix.

John: what do you recommend?

The native code might look something like this:

if (defined CSSMatrix)
  return new CSSMatrix(spec);
else
  return new WebKitCSSMatrix(spec);

Powered by Google App Engine
This is Rietveld 408576698