Issue 8566003: Revert various changes to Link factories.

Issue 8566003: Revert various changes to Link factories. (Closed)

Created:
9 years, 1 month ago by ahe

Modified:
9 years, 1 month ago

Reviewers:
jimhug, ngeoffray, kasperl, Ivan Posva

CC:
reviews_dartlang.org, srdjan

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert various changes to Link factories. Also, hack/work around bugs in VM and Frog to get LinkFactory to work. Committed: https://code.google.com/p/dart/source/detail?r=1504

Patch Set 2 : frogsh #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -291 lines)			Patch
M	dart/frog/frogsh	View	1	54 chunks	+75 lines, -267 lines	0 comments	Download
M	dart/frog/leg/scanner/listener.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/frog/leg/scanner/scannerlib.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	dart/frog/leg/scanner/source_list.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/frog/leg/tree/nodes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/frog/leg/tree/tree.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	dart/frog/leg/util/link.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/frog/leg/util/link_implementation.dart	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	dart/frog/tests/leg/src/LinkTest.dart	View		2 chunks	+6 lines, -5 lines	2 comments	Download
M	dart/frog/type.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/tests/language/src/NonParameterizedFactoryTest.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

http://codereview.chromium.org/8566003/diff/3001/dart/frog/tests/leg/src/LinkTest.dart File dart/frog/tests/leg/src/LinkTest.dart (right): http://codereview.chromium.org/8566003/diff/3001/dart/frog/tests/leg/src/LinkTest.dart#newcode14 dart/frog/tests/leg/src/LinkTest.dart:14: // TODO(ahe): Fails in checked mode. Please verify whether ...

9 years, 1 month ago (2011-11-14 16:32:20 UTC) #3

ahe

9 years, 1 month ago (2011-11-15 16:12:40 UTC) #4

http://codereview.chromium.org/8566003/diff/3001/dart/frog/tests/leg/src/Link...
File dart/frog/tests/leg/src/LinkTest.dart (right):

http://codereview.chromium.org/8566003/diff/3001/dart/frog/tests/leg/src/Link...
dart/frog/tests/leg/src/LinkTest.dart:14: // TODO(ahe): Fails in checked mode.
On 2011/11/14 16:32:21, Ivan Posva wrote:
> Please verify whether this statement is still correct!

It isn't, and I have remove the comment in a new CL.

This problem had nothing to do with generics, it was another issue related to
factories. I have given Regis an example of this.

Expand Messages | Collapse Messages