Revert various changes to Link factories.

dart/frog/tests/leg/src/LinkTest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #import('../../../leg/util/util.dart');
 #import('../../../leg/util/util_implementation.dart');
 
 main() {
-  test(LinkFactory.createLink('three').prepend(2).prepend('one'),
+  test(new Link<Comparable>('three').prepend(2).prepend('one'),
        ['one', 2, 'three']);
-  test(LinkFactory.createLink(3).prepend('two').prepend(1), [1, 'two', 3]);
-  test(LinkFactory.createLink('single'), ['single']);
+  test(new Link<Comparable>(3).prepend('two').prepend(1), [1, 'two', 3]);
+  test(new Link<String>('single'), ['single']);
   test(new LinkTail(), []);
-  testFromList([]);
+  // TODO(ahe): Fails in checked mode.

[Ivan Posva, 2011/11/14 16:32:21]

Please verify whether this statement is still correct!

[ahe, 2011/11/15 16:12:40]

It isn't, and I have remove the comment in a new CL.

This problem had nothing to do with generics, it was another issue related to
factories. I have given Regis an example of this.

+  // testFromList([]);
   testFromList([0]);
   testFromList([0, 1]);
   testFromList([0, 1, 2]);
   testFromList([0, 1, 2, 3]);
   testFromList([0, 1, 2, 3, 4]);
   testFromList([0, 1, 2, 3, 4, 5]);
 }
 
 testFromList(List list) {
-  test(LinkFactory.createFromList(list), list);
+  test(new Link.fromList(list), list);
 }
 
 test(Link link, List list) {
   Expect.equals(list.isEmpty(), link.isEmpty());
   int i = 0;
   for (var element in link.toList()) {
     Expect.equals(list[i++], element);
   }
   Expect.equals(list.length, i);
   i = 0;
   for (var element in link) {
     Expect.equals(list[i++], element);
   }
   Expect.equals(list.length, i);
   i = 0;
   for (; !link.isEmpty(); link = link.tail) {
     Expect.equals(list[i++], link.head);
   }
   Expect.equals(list.length, i);
   Expect.isTrue(link.isEmpty());
 }