Issue 8555024: - Avoid allocating variable length arrays on the stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8555024: - Avoid allocating variable length arrays on the stack. (Closed)

Created:
9 years, 1 month ago by Ivan Posva

Modified:
9 years, 1 month ago

Reviewers:
tobyr, Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Avoid allocating variable length arrays on the stack. - Fix C++ warning about copying vtables. - Use correct delete for PortMap entries. Committed: https://code.google.com/p/dart/source/detail?r=1538

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
M	bin/process_linux.cc	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
M	bin/process_macos.cc	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
M	vm/globals.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	vm/port.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tobyr

http://codereview.chromium.org/8555024/diff/3001/bin/process_linux.cc File bin/process_linux.cc (right): http://codereview.chromium.org/8555024/diff/3001/bin/process_linux.cc#newcode209 bin/process_linux.cc:209: delete program_arguments; Shouldn't this (and below) also be delete[]? ...

9 years, 1 month ago (2011-11-15 17:41:16 UTC) #3

Ivan Posva

9 years, 1 month ago (2011-11-15 17:47:01 UTC) #4

Thanks! Fixed.

-Ivan

http://codereview.chromium.org/8555024/diff/3001/bin/process_linux.cc
File bin/process_linux.cc (right):

http://codereview.chromium.org/8555024/diff/3001/bin/process_linux.cc#newcode209
bin/process_linux.cc:209: delete program_arguments;
On 2011/11/15 17:41:16, tobyr wrote:
> Shouldn't this (and below) also be delete[]? Ditto for process_macos.cc.

Done.

Expand Messages | Collapse Messages