- Avoid allocating variable length arrays on the stack.

bin/process_linux.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/process.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stdio.h>
@@ skipping 171 matching lines @@
     close(read_err[0]);
     close(read_err[1]);
     close(write_out[0]);
     close(write_out[1]);
     close(exec_control[0]);
     close(exec_control[1]);
     fprintf(stderr, "fcntl failed: %s\n", os_error_message);
     return errno;
   }
 
-  char* program_arguments[arguments_length + 2];
+  char** program_arguments = new char*[arguments_length + 2];
   program_arguments[0] = const_cast<char *>(path);
   for (int i = 0; i < arguments_length; i++) {
     program_arguments[i + 1] = arguments[i];
   }
   program_arguments[arguments_length + 1] = NULL;
 
   struct sigaction act;
   bzero(&act, sizeof(act));
   act.sa_sigaction = ExitHandler;
   act.sa_flags = SA_NOCLDSTOP | SA_SIGINFO;
   if (sigaction(SIGCHLD, &act, 0) != 0) {
     perror("Process start: setting signal handler failed");
   }
   pid = fork();
   if (pid < 0) {
     SetChildOsErrorMessage(os_error_message, os_error_message_len);
+    delete[] program_arguments;
     close(read_in[0]);
     close(read_in[1]);
     close(read_err[0]);
     close(read_err[1]);
     close(write_out[0]);
     close(write_out[1]);
     close(exec_control[0]);
     close(exec_control[1]);
     return errno;
   } else if (pid == 0) {
@@ skipping 29 matching lines @@
         FDUtils::WriteToBlocking(
             exec_control[1], &child_errno, sizeof(child_errno));
     if (bytes_written == sizeof(child_errno)) {
       FDUtils::WriteToBlocking(
           exec_control[1], os_error_message, strlen(os_error_message) + 1);
     }
     close(exec_control[1]);
     exit(1);
   }
 
+  // The arguments for the spawned process are not needed any longer.
+  delete[] program_arguments;
+
   int event_fds[2];
   result = pipe(event_fds);
   if (result < 0) {
     SetChildOsErrorMessage(os_error_message, os_error_message_len);
     close(read_in[0]);
     close(read_in[1]);
     close(read_err[0]);
     close(read_err[1]);
     close(write_out[0]);
     close(write_out[1]);
@@ skipping 66 matching lines @@
   if (result == -1) {
     return false;
   }
   return true;
 }
 
 
 void Process::Exit(intptr_t id) {
   RemoveProcess(id);
 }