Issue 8528050: Fix throwing ObjectNotClosure instead of null exception if closure is null.

Issue 8528050: Fix throwing ObjectNotClosure instead of null exception if closure is null. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix throwing ObjectNotClosure instead of null exception if closure is null. Fix integer compareTo if other is a double NaN. Fix Expect.stringEqual to accept null as arguments. Update co19 status file. Committed: https://code.google.com/p/dart/source/detail?r=1539

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -144 lines)			Patch
M	corelib/src/expect.dart	View	1 2 3	1 chunk	+48 lines, -46 lines	0 comments	Download
M	runtime/lib/integers.dart	View	1 2	1 chunk	+12 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3	2 chunks	+2 lines, -5 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	5 chunks	+61 lines, -81 lines	0 comments	Download
M	tests/language/language.status	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/language/src/CallThroughNullGetterTest.dart	View	1 2 3	2 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM after removing the other NullPointerException also. http://codereview.chromium.org/8528050/diff/8/corelib/src/expect.dart File corelib/src/expect.dart (right): http://codereview.chromium.org/8528050/diff/8/corelib/src/expect.dart#newcode132 corelib/src/expect.dart:132: if ((expected ...

9 years, 1 month ago (2011-11-15 02:46:06 UTC) #2

srdjan

9 years, 1 month ago (2011-11-15 17:43:04 UTC) #3

Thanks!

http://codereview.chromium.org/8528050/diff/8/corelib/src/expect.dart
File corelib/src/expect.dart (right):

http://codereview.chromium.org/8528050/diff/8/corelib/src/expect.dart#newcode132
corelib/src/expect.dart:132: if ((expected == null) || (actual == null)) {
On 2011/11/15 02:46:06, asiva wrote:
> expected === null || actual === null

Done.

http://codereview.chromium.org/8528050/diff/8/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/8528050/diff/8/runtime/vm/code_generator.cc#ne...
runtime/vm/code_generator.cc:781: }
On 2011/11/15 02:46:06, asiva wrote:
> There is another method in this file caled ResolveImplicitClosureThroughGetter
> which also throws NullPointerException where it should throw
> ObjectNotClosureException.

Done.

Expand Messages | Collapse Messages