Fix throwing ObjectNotClosure instead of null exception if closure is null.

runtime/vm/code_generator.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
@@ skipping 754 matching lines @@
 
 // Report that an object is not a closure.
 // Arg0: non-closure object.
 // Arg1: arguments array.
 DEFINE_RUNTIME_ENTRY(ReportObjectNotClosure, 2) {
   ASSERT(arguments.Count() ==
          kReportObjectNotClosureRuntimeEntry.argument_count());
   const Instance& bad_closure = Instance::CheckedHandle(arguments.At(0));
   if (bad_closure.IsNull()) {
     GrowableArray<const Object*> args;
-    Exceptions::ThrowByType(Exceptions::kNullPointer, args);
+    Exceptions::ThrowByType(Exceptions::kObjectNotClosure, args);
   }
   // const Array& arguments = Array::CheckedHandle(arguments.At(1));
   OS::PrintErr("object '%s' is not a closure\n", bad_closure.ToCString());
   GrowableArray<const Object*> args;
   Exceptions::ThrowByType(Exceptions::kObjectNotClosure, args);
 }

[siva, 2011/11/15 02:46:06]

There is another method in this file caled ResolveImplicitClosureThroughGetter
which also throws NullPointerException where it should throw
ObjectNotClosureException.

[srdjan, 2011/11/15 17:43:04]

Done.

 
 
 DEFINE_RUNTIME_ENTRY(ClosureArgumentMismatch, 0) {
   ASSERT(arguments.Count() ==
          kClosureArgumentMismatchRuntimeEntry.argument_count());
   GrowableArray<const Object*> args;
   Exceptions::ThrowByType(Exceptions::kClosureArgumentMismatch, args);
 }
 
 
@@ skipping 205 matching lines @@
       }
     }
   }
   // The cache is null terminated, therefore the loop above should never
   // terminate by itself.
   UNREACHABLE();
   return Code::null();
 }
 
 }  // namespace dart