Adding frogium: a frog-chromium architecture that runs tests in chromium that

Adding frogium: a frog-chromium architecture that runs tests in chromium that
were compiled with frog.

Committed: https://code.google.com/p/dart/source/detail?r=1440

[Siggi Cherem (dart-lang), 2011-11-11 01:25:51]

http://codereview.chromium.org/8523024/diff/1/client/tests/client/client.status
File client/tests/client/client.status (right):

http://codereview.chromium.org/8523024/diff/1/client/tests/client/client.stat...
client/tests/client/client.status:24: [ $component == frogium ]
I want to add things first before I investigate why so many things are failing

http://codereview.chromium.org/8523024/diff/1/frog/frog.py
File frog/frog.py (right):

http://codereview.chromium.org/8523024/diff/1/frog/frog.py#newcode201
frog/frog.py:201: compiler_cmd.append(join(HOME, 'frogc.dart'))
this allows running test.py from the top-level directory

http://codereview.chromium.org/8523024/diff/1/frog/value.dart
File frog/value.dart (right):

http://codereview.chromium.org/8523024/diff/1/frog/value.dart#newcode67
frog/value.dart:67: if (_typeIsVarOrParameterType && name == '\$ne') {
is is to fix observable_tests, it was failing because we had a != comparison on
a variable of a generic type:

class F<T> {
  m() {
    T foo = ...;
    if (foo != null) ...
  }
}

[Emily Fortuna, 2011-11-11 01:44:14]

lgtm. 
+1 for the name frogium

On 2011/11/11 01:25:51, sigmund wrote:
>
http://codereview.chromium.org/8523024/diff/1/client/tests/client/client.status
> File client/tests/client/client.status (right):
> 
>
http://codereview.chromium.org/8523024/diff/1/client/tests/client/client.stat...
> client/tests/client/client.status:24: [ $component == frogium ]
> I want to add things first before I investigate why so many things are failing
> 
> http://codereview.chromium.org/8523024/diff/1/frog/frog.py
> File frog/frog.py (right):
> 
> http://codereview.chromium.org/8523024/diff/1/frog/frog.py#newcode201
> frog/frog.py:201: compiler_cmd.append(join(HOME, 'frogc.dart'))
> this allows running test.py from the top-level directory
> 
> http://codereview.chromium.org/8523024/diff/1/frog/value.dart
> File frog/value.dart (right):
> 
> http://codereview.chromium.org/8523024/diff/1/frog/value.dart#newcode67
> frog/value.dart:67: if (_typeIsVarOrParameterType && name == '\$ne') {
> is is to fix observable_tests, it was failing because we had a != comparison
on
> a variable of a generic type:
> 
> class F<T> {
>   m() {
>     T foo = ...;
>     if (foo != null) ...
>   }
> }

[Jennifer Messerly, 2011-11-11 01:49:11]

On 2011/11/11 01:44:14, Emily Fortuna wrote:
> lgtm. 
> +1 for the name frogium
> 
> On 2011/11/11 01:25:51, sigmund wrote:
> >
>
http://codereview.chromium.org/8523024/diff/1/client/tests/client/client.status
> > File client/tests/client/client.status (right):
> > 
> >
>
http://codereview.chromium.org/8523024/diff/1/client/tests/client/client.stat...
> > client/tests/client/client.status:24: [ $component == frogium ]
> > I want to add things first before I investigate why so many things are
failing
> > 
> > http://codereview.chromium.org/8523024/diff/1/frog/frog.py
> > File frog/frog.py (right):
> > 
> > http://codereview.chromium.org/8523024/diff/1/frog/frog.py#newcode201
> > frog/frog.py:201: compiler_cmd.append(join(HOME, 'frogc.dart'))
> > this allows running test.py from the top-level directory
> > 
> > http://codereview.chromium.org/8523024/diff/1/frog/value.dart
> > File frog/value.dart (right):
> > 
> > http://codereview.chromium.org/8523024/diff/1/frog/value.dart#newcode67
> > frog/value.dart:67: if (_typeIsVarOrParameterType && name == '\$ne') {
> > is is to fix observable_tests, it was failing because we had a != comparison
> on
> > a variable of a generic type:
> > 
> > class F<T> {
> >   m() {
> >     T foo = ...;
> >     if (foo != null) ...
> >   }
> > }

lgtm too!

[ngeoffray, 2011-11-11 09:26:59]

Very nice again.

http://codereview.chromium.org/8523024/diff/4002/tools/testing/architecture.py
File tools/testing/architecture.py (right):

http://codereview.chromium.org/8523024/diff/4002/tools/testing/architecture.p...
tools/testing/architecture.py:439: build_root = utils.GetBuildRoot(OS_GUESS,
self.mode, 'ia32')
build_root is not needed here.

It looks like WebDriverArchitecture could extend FrogChromiumArchitecture and
share GetCompileCommand.

[jimhug, 2011-11-11 14:50:56]

lgtm