Adding frogium: a frog-chromium architecture that runs tests in chromium that

frog/value.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Represents a meta-value for code generation.
  */
 class Value {
   /** The [Type] of the [Value]. */
   Type type;
 
   /** The code to generate this value. */
   String code;
 
   /** The source location that created this value for error messages. */
   SourceSpan span;
 
   /** Is this a reference to super? */
   bool isSuper;
 
   /** Is this a pretend first-class type? */
   bool isType;
 
   /** If we reference this value multiple times, do we need a temp? */
   bool needsTemp;
 
+  // TODO(jmesserly): until reified generics are fixed, treat ParameterType as
+  // "var".
+  bool get _typeIsVarOrParameterType() => type.isVar || type is ParameterType;
+
   Value(this.type, this.code, this.span,
         // TODO(sigmund): reorder, so that needsTemp comes first.
         [this.isSuper = false, this.needsTemp = true, this.isType = false]) {
     if (type == null) type = world.varType;
   }
 
   /** Is this value a constant expression? */
   bool get isConst() => false;
 
   // TODO(jimhug): Fix these names once get/set are truly pseudo-keywords.
@@ skipping 13 matching lines @@
     final member = _resolveMember(context, name, node, isDynamic);
     if (member != null) {
       return member._set(context, node, this, value, isDynamic);
     } else {
       return invokeNoSuchMethod(context, 'set:$name', node,
           new Arguments(null, [value]));
     }
   }
 
 
-
   Value invoke(MethodGenerator context, String name, Node node, Arguments args,
       [bool isDynamic=false]) {
     // TODO(jimhug): The != method is weird - understand it better.
-    if (type.isVar && name == '\$ne') {
+    if (_typeIsVarOrParameterType && name == '\$ne') {

[Siggi Cherem (dart-lang), 2011/11/11 01:25:51]

is is to fix observable_tests, it was failing because we had a != comparison on
a variable of a generic type:

class F<T> {
  m() {
    T foo = ...;
    if (foo != null) ...
  }
}

       if (args.values.length != 1) {
         world.warning('wrong number of arguments for !=', node.span);
       }
       world.gen.corejs.useOperator('\$ne');
       return new Value(null, '\$ne($code, ${args.values[0].code})', node.span);
     }
 
     // TODO(jmesserly): it'd be nice to remove these special cases
     // We could create a $call (and $ne) in world members, and have
     // those guys handle the canInvoke/Invoke logic.
@@ skipping 15 matching lines @@
     var member = _resolveMember(context, name, node, isDynamic);
     if (member == null) {
       return invokeNoSuchMethod(context, name, node, args);
     } else {
       return member.invoke(context, node, this, args, isDynamic);
     }
   }
 
   bool canInvoke(MethodGenerator context, String name, Arguments args) {
     // TODO(jimhug): The != method is weird - understand it better.
-    if (type.isVar && name == '\$ne') {
+    if (_typeIsVarOrParameterType && name == '\$ne') {
       return true;
     }
 
     if (type.isVarOrFunction && name == '\$call') {
       return true;
     }
 
     var member = _resolveMember(context, name, null, isDynamic:true);
     return member != null && member.canInvoke(context, args);
   }
@@ skipping 17 matching lines @@
       return type.getMember(name);
     } else {
       return type.resolveMember(name);
     }
   }
 
   // TODO(jimhug): Better type here - currently is union(Member, MemberSet)
   _resolveMember(MethodGenerator context, String name, Node node,
         [bool isDynamic=false]) {
 
-    // TODO(jmesserly): until reified generic lists are fixed, treat
-    // ParameterType as "var".
     var member;
-    if (!type.isVar && type is! ParameterType) {
+    if (!_typeIsVarOrParameterType) {
       member = _tryResolveMember(context, name);
 
       if (member != null && isType && !member.isStatic) {
         if (!isDynamic) {
           world.error('can not refer to instance member as static', node.span);
         }
         return null;
       }
 
       if (member == null && !isDynamic && !_hasOverriddenNoSuchMethod()) {
@@ skipping 512 matching lines @@
 
     // Then look for members in my library.
     member = home.library.lookup(name, span);
     if (member != null) {
       return member;
     }
 
     return null;
   }
 }