first stage of Value cleanups

Adds source information to all values (with no detectable perf impact).  Uses Value more consistently for operations in gen.  Starts down the path of cleaning up this type.

Committed: https://code.google.com/p/dart/source/detail?r=1430

[jimhug, 2011-11-10 22:13:51]

TBR

[Jennifer Messerly, 2011-11-10 22:50:39]

lgtm

http://codereview.chromium.org/8523012/diff/4001/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8523012/diff/4001/frog/gen.dart#newcode1536
frog/gen.dart:1536: return new Value(method.declaringType, 'this', node != null
? node.span : null,
this code is screaming for a ?. operator :)

Maybe something like a top level "spanOf(Node n) => n != null ? n.span : n;"
function if we're going to be doing it a lot?

http://codereview.chromium.org/8523012/diff/4001/frog/gen.dart#newcode1686
frog/gen.dart:1686: //var right = members._get(this, position, x);
remove? Or make a TODO?

http://codereview.chromium.org/8523012/diff/4001/frog/gen.dart#newcode1703
frog/gen.dart:1703: // Also make sure we dont't try to set a method.
guessing we're on a path to removing this duplication?
Might be worth a TODO though. Unless this is just your next checkin ;)

http://codereview.chromium.org/8523012/diff/4001/frog/gen.dart#newcode2045
frog/gen.dart:2045: return _makeThisOrType(node.span).get_(this, name, node);
awesome cleanup!

http://codereview.chromium.org/8523012/diff/4001/frog/gen.dart#newcode2049
frog/gen.dart:2049: // TODO(jimhug): Probably goes away to be fully replaced by
doesNotUnder
noSuchMethod?

http://codereview.chromium.org/8523012/diff/4001/frog/gen.dart#newcode2225
frog/gen.dart:2225: // TODO(jimhug): Need source locations.
synthetic stubs shouldn't need them? The idea is these args are only used to
generate code that we know won't have any errors (due to var type, etc).

http://codereview.chromium.org/8523012/diff/4001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8523012/diff/4001/frog/member.dart#newcode151
frog/member.dart:151: // TODO(jimhug): Needs better source location?
I would hope that "canInvoke" can't emit errors.

http://codereview.chromium.org/8523012/diff/4001/frog/member.dart#newcode223
frog/member.dart:223: // TODO(jmesserly): named args
btw, I think the VM is the main blocker here. Maybe we just need to make them
not use "this." for now so we can fix all the callsites.

http://codereview.chromium.org/8523012/diff/4001/frog/value.dart
File frog/value.dart (right):

http://codereview.chromium.org/8523012/diff/4001/frog/value.dart#newcode16
frog/value.dart:16: SourceSpan span;
this makes me happy. I bet we can start slowly ratcheting down the "node"s we
pass everywhere.

http://codereview.chromium.org/8523012/diff/4001/frog/value.dart#newcode126
frog/value.dart:126: _tryResolveMember(MethodGenerator context, String name) {
funny! I had it factored this way at one point, but I didn't have any other
callers. :)

http://codereview.chromium.org/8523012/diff/4001/frog/value.dart#newcode642
frog/value.dart:642: class BareValue extends Value {
+1

[jimhug, 2011-11-11 15:46:53]

Thanks for all the comments!  You should expect to see them all addressed in my
next CL.