Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: frog/var_member.dart

Issue 8523012: first stage of Value cleanups (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebased Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/var_member.dart
diff --git a/frog/var_member.dart b/frog/var_member.dart
index f6ada404cca6b62ef2f0c59f57ca86b9114f6294..9c15218e2b4301fb65d7cb6db074cfc14eeb51c4 100644
--- a/frog/var_member.dart
+++ b/frog/var_member.dart
@@ -14,7 +14,7 @@ class VarMember {
Value invoke(MethodGenerator context, Node node, Value target, Arguments args) {
return new Value(returnType,
- '${target.code}.$name(${args.getCode()})');
+ '${target.code}.$name(${args.getCode()})', node.span);
}
}
@@ -196,7 +196,7 @@ class VarMethodSet extends VarMember {
for (var member in members) {
// Invoke the member with the stub args (this gives us the method body),
// then create the stub method.
- final target = new Value(member.declaringType, 'this');
+ final target = new Value(member.declaringType, 'this', node.span);
var result = member.invoke(context, node, target, args);
var stub = new VarMethodStub(name, member, args, result);
@@ -211,7 +211,7 @@ class VarMethodSet extends VarMember {
}
// Finally, invoke noSuchMethod
- final target = new Value(world.objectType, 'this');
+ final target = new Value(world.objectType, 'this', node.span);
var result = target.invokeNoSuchMethod(context, baseName, node, args);
var stub = new VarMethodStub(name, null, args, result);
if (_fallbackStubs.length == 0) {
« frog/value.dart ('K') | « frog/value.dart ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698