Set the loaded_ flag in RawLibrary when it is completely loaded. This

Change loaded_ flag in RawLibrary to load_state_ in order to register different
states of the load process.
This state can then be used to ensure we report errors on duplicate loads.
Committed: https://code.google.com/p/dart/source/detail?r=1643

[turnidge, 2011-11-16 00:51:36]

lgtm w/ comment

http://codereview.chromium.org/8520030/diff/1/vm/dart_api_impl.cc
File vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8520030/diff/1/vm/dart_api_impl.cc#newcode404
vm/dart_api_impl.cc:404: }
Does it make sense to move this into CompileSource?

[siva, 2011-11-16 18:57:31]

http://codereview.chromium.org/8520030/diff/1/vm/dart_api_impl.cc
File vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8520030/diff/1/vm/dart_api_impl.cc#newcode404
vm/dart_api_impl.cc:404: }
CompileSource is also called from Dart_LoadSource and we 
it we set it inside CompileSoucce then we would be setting the flag prematurely.

On 2011/11/16 00:51:36, turnidge wrote:
> Does it make sense to move this into CompileSource?

[turnidge, 2011-11-16 19:24:33]

Ok.

On 2011/11/16 18:57:31, asiva wrote:
> http://codereview.chromium.org/8520030/diff/1/vm/dart_api_impl.cc
> File vm/dart_api_impl.cc (right):
> 
> http://codereview.chromium.org/8520030/diff/1/vm/dart_api_impl.cc#newcode404
> vm/dart_api_impl.cc:404: }
> CompileSource is also called from Dart_LoadSource and we 
> it we set it inside CompileSoucce then we would be setting the flag
prematurely.
> 
> On 2011/11/16 00:51:36, turnidge wrote:
> > Does it make sense to move this into CompileSource?

[siva, 2011-11-17 01:10:24]

Use a load_state_ instead of the boolean loaded_ flag.

[turnidge, 2011-11-17 23:36:07]

lgtm