Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 8509002: Revert "Post on the error handler in the Directory API when errors are encountered." (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Post on the error handler in the Directory API when errors are encountered." Breaks the mac build because of differences in strerror_r behavior. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -111 lines) Patch
M runtime/bin/directory_impl.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/directory_posix.cc View 5 chunks +25 lines, -60 lines 0 comments Download
M runtime/bin/directory_win.cc View 2 chunks +23 lines, -51 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-09 08:33:35 UTC) #1
Søren Gjesse
9 years, 1 month ago (2011-11-09 08:42:43 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698