Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: runtime/bin/directory_impl.dart

Issue 8509002: Revert "Post on the error handler in the Directory API when errors are encountered." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/directory_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory_impl.dart
diff --git a/runtime/bin/directory_impl.dart b/runtime/bin/directory_impl.dart
index 485dfadfcac5e6b83b22824b6f9ee4ff70552399..4e962e41e1e9f50d5f623f02262120a82f6d2ad7 100644
--- a/runtime/bin/directory_impl.dart
+++ b/runtime/bin/directory_impl.dart
@@ -36,6 +36,7 @@ class _Directory implements Directory {
bool existsSync() {
int exists = _exists(_path);
if (exists < 0) {
+ // TODO(ager): Supply a better error message.
throw new DirectoryException("Diretory exists test failed: $_path");
}
return (exists == 1);
@@ -43,12 +44,14 @@ class _Directory implements Directory {
void createSync() {
if (!_create(_path)) {
+ // TODO(ager): Supply a better error message.
throw new DirectoryException("Directory creation failed: $_path");
}
}
void deleteSync() {
if (!_delete(_path)) {
+ // TODO(ager): Supply a better error message.
throw new DirectoryException("Directory deletion failed: $_path");
}
}
« no previous file with comments | « no previous file | runtime/bin/directory_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698