Issue 8506013: Correct the sign of exit codes for the process library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8506013: Correct the sign of exit codes for the process library. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Correct the sign of exit codes for the process library. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1356

Patch Set 3 : Cosmetic Windows changes #

Total comments: 2

Patch Set 4 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -20 lines)			Patch
M	runtime/bin/process_impl.dart	View	1 2 3	2 chunks	+13 lines, -3 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View		1 chunk	+13 lines, -6 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View		1 chunk	+13 lines, -6 lines	0 comments	Download
M	runtime/bin/process_win.cc	View	1 2	1 chunk	+14 lines, -4 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/8506013/diff/3001/runtime/bin/process_impl.dart File runtime/bin/process_impl.dart (right): http://codereview.chromium.org/8506013/diff/3001/runtime/bin/process_impl.dart#newcode69 runtime/bin/process_impl.dart:69: return (ints[8] == 0) ? code : -code; ...

9 years, 1 month ago (2011-11-09 15:12:45 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-09 15:37:11 UTC) #3

http://codereview.chromium.org/8506013/diff/3001/runtime/bin/process_impl.dart
File runtime/bin/process_impl.dart (right):

http://codereview.chromium.org/8506013/diff/3001/runtime/bin/process_impl.dar...
runtime/bin/process_impl.dart:69: return (ints[8] == 0) ? code : -code;
On 2011/11/09 15:12:45, Søren Gjesse wrote:
> Should we assert that ints[8] is either 0 or 1 and that ints[9], ints[10] and
> ints[11] are zero?
>
> Maybe refactor converting 4 bytes to an int into a separate method.

Thanks! Done. I'm using that method to get the negative indication as well and I
assert that it is either 0 or 1.