tools/testing/dart/test_runner.dart - Issue 8506013: Correct the sign of exit codes for the process library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8506013: Correct the sign of exit codes for the process library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index 0e22e119e324f39244d93f0dbffa92ae522bf723..0e4c13b3d3a4ad809cd844aca1c82a71e6937f18 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -84,7 +84,7 @@ class TestOutput {

bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);

- bool get hasCrashed() => !timedOut && exitCode != 255 && exitCode != 0;

+ bool get hasCrashed() => !timedOut && exitCode != -1 && exitCode != 0;

bool get hasTimedOut() => timedOut;

« no previous file with comments | « runtime/bin/process_win.cc ('k') | no next file » | no next file with comments »