More info in disassembled code

More info in disassembled code

Print out first 5 elements of an array object, rather than
just 'Array'. This helps in particular in disassembled
method and stub calls which now print the content of the
IC cache and ArgumentsDescriptor arrays. E.g.:

0x7404a5    ff7508            push [ebp+0x8]
0x7404a8    ff750c            push [ebp+0xc]
0x7404ab    b9012f7000        mov ecx,0x702f01  Array[bitAndFromInteger, 1, null, null]
0x7404b0    bafd050003        mov edx,0x30005fd  Array[2, 2, null]
0x7404b5    e8b6fcffff        call 0x740170  [stub: InlineCache]
0x7404ba    83c408            add esp,0x8
Committed: https://code.google.com/p/dart/source/detail?r=1493

[hausner, 2011-11-12 00:45:35]

TBR.

[siva, 2011-11-12 01:11:55]

lgtm

http://codereview.chromium.org/8491061/diff/1/runtime/vm/disassembler_ia32.cc
File runtime/vm/disassembler_ia32.cc (right):

http://codereview.chromium.org/8491061/diff/1/runtime/vm/disassembler_ia32.cc...
runtime/vm/disassembler_ia32.cc:399: const Array& arr =
Array::CheckedHandle(obj.raw());
You have already checked it is an array above so why not just use
Array::Handle(obj.raw());

http://codereview.chromium.org/8491061/diff/1/runtime/vm/disassembler_ia32.cc...
runtime/vm/disassembler_ia32.cc:401: if (len > 5) len = 5;  // At max print
first 5 elements.
Print a max of 5 elements.

[hausner, 2011-11-12 01:21:08]

Thanks, will fix in a follow-up checkin.