More info in disassembled code

runtime/vm/disassembler_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/disassembler.h"
 
 #include "vm/allocation.h"
@@ skipping 376 matching lines @@
 
 
 void X86Decoder::PrintAddress(uword addr) {
   NoGCScope no_gc;
   char addr_buffer[32];
   OS::SNPrint(addr_buffer, sizeof(addr_buffer), "%p", addr);
   Print(addr_buffer);
   // Try to print as heap object or stub name
   if (!Isolate::Current()->heap()->CodeContains(addr) &&
       Isolate::Current()->heap()->Contains(addr - kHeapObjectTag)) {
+    Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
+    if (obj.IsArray()) {
+      const Array& arr = Array::CheckedHandle(obj.raw());

[siva, 2011/11/12 01:11:55]

You have already checked it is an array above so why not just use
Array::Handle(obj.raw());

+      intptr_t len = arr.Length();
+      if (len > 5) len = 5;  // At max print first 5 elements.

[siva, 2011/11/12 01:11:55]

Print a max of 5 elements.

+      Print("  Array[");
+      int i = 0;
+      while (i < len) {
+        obj = arr.At(i);
+        if (i > 0) Print(", ");
+        Print(obj.ToCString());
+        i++;
+      }
+      if (i < arr.Length()) Print(", ...");
+      Print("]");
+      return;
+    }
     Print("  '");
-    const Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
     Print(obj.ToCString());
     Print("'");
   } else {
     // 'addr' is not an object, but probably a code address.
     const char* name_of_stub = StubCode::NameOfStub(addr);
     if (name_of_stub != NULL) {
       Print("  [stub: ");
       Print(name_of_stub);
       Print("]");
     } else {
@@ skipping 1096 matching lines @@
 
 const char* Disassembler::RegisterName(Register reg) {
   ASSERT(0 <= reg);
   ASSERT(reg < kMaxCPURegisters);
   return (cpu_regs[reg]);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32