Issue 8491055: Second attempt at finalizing all classes in the VM (fix issue 364).

Issue 8491055: Second attempt at finalizing all classes in the VM (fix issue 364). (Closed)

Created:
9 years, 1 month ago by regis

Modified:
9 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Second attempt at finalizing all classes in the VM (fix issue 364). Committed: https://code.google.com/p/dart/source/detail?r=1475

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+406 lines, -306 lines)			Patch
M	runtime/lib/error.cc	View	1	2 chunks	+17 lines, -12 lines	0 comments	Download
M	runtime/vm/class_finalizer.h	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	15 chunks	+151 lines, -81 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	1 chunk	+9 lines, -8 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1	4 chunks	+15 lines, -11 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	20 chunks	+196 lines, -181 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	5 chunks	+9 lines, -4 lines	0 comments	Download
M	tests/language/src/FunctionTypeAliasNegativeTest.dart	View	1	1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM http://codereview.chromium.org/8491055/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/8491055/diff/1/runtime/vm/object.cc#newcode341 runtime/vm/object.cc:341: RawClass* Object::CreateAndRegisterCoreInterface(const char* cname, May want to change ...

9 years, 1 month ago (2011-11-11 21:32:04 UTC) #2

regis

9 years, 1 month ago (2011-11-11 21:37:37 UTC) #3

Thanks!

http://codereview.chromium.org/8491055/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8491055/diff/1/runtime/vm/object.cc#newcode341
runtime/vm/object.cc:341: RawClass* Object::CreateAndRegisterCoreInterface(const
char* cname,
On 2011/11/11 21:32:04, srdjan wrote:
> May want to change it to CreateAndRegisterInterface, since the 'Core' part is
> specified by the argument, and could be any library.

Done.

http://codereview.chromium.org/8491055/diff/1/runtime/vm/object.cc#newcode351
runtime/vm/object.cc:351: void Object::RegisterCoreImplClass(const Class& cls,
On 2011/11/11 21:32:04, srdjan wrote:
> Ditto for CoreImpl

Done.

http://codereview.chromium.org/8491055/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

http://codereview.chromium.org/8491055/diff/1/runtime/vm/object.h#newcode432
runtime/vm/object.h:432: // The type argument vector is flatten and includes the
type arguments of
On 2011/11/11 21:32:04, srdjan wrote:
> flattened

Done.

Expand Messages | Collapse Messages