runtime/vm/code_generator_ia32.cc - Issue 8491055: Second attempt at finalizing all classes in the VM (fix issue 364).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8491055: Second attempt at finalizing all classes in the VM (fix issue 364). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator_ia32.cc

===================================================================

--- runtime/vm/code_generator_ia32.cc (revision 1474)

+++ runtime/vm/code_generator_ia32.cc (working copy)

@@ -1389,11 +1389,10 @@

const Bool& bool_true = Bool::ZoneHandle(Bool::True());

const Bool& bool_false = Bool::ZoneHandle(Bool::False());

- // All instances are of type Object.

+ // All instances are of a subtype of the Object type.

const Type& object_type =

Type::Handle(Isolate::Current()->object_store()->object_type());

if (type.IsInstantiated() && object_type.IsSubtypeOf(type)) {

- // All objects are an instance of the Object class.

__ PushObject(negate_result ? bool_false : bool_true);

return;

}

« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »