Renaming:

Renaming:

Dart_ObjectToString -> Dart_ToString
Dart_Objects_Equal -> Dart_ObjectEquals
Dart_IsInstanceOf -> Dart_ObjectIsType
Dart_ReThrowException -> Dart_RethrowException

Added:

Dart_IsSame: === operation

Added a couple of tests.

[Ivan Posva, 2011-11-07 23:10:45]

First round of comments.

-Ivan

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:464: DART_EXPORT Dart_Handle
Dart_ToString(Dart_Handle object);
Dart_ToString and Dart_IsSame are functions that should apply to all kinds of
handles. We should probably move them out of the // --- Objects --- area.

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:479: DART_EXPORT Dart_Handle Dart_Equals(Dart_Handle
obj1,
This should really be Dart_ObjectEquals to be consistent with other typed API.

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:496: DART_EXPORT Dart_Handle
Dart_TripleEquals(Dart_Handle obj1,
Dart_IsSame as discussed offline.

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:512: DART_EXPORT Dart_Handle Dart_IsType(Dart_Handle
object,
Dart_ObjectIsType, again to be consistent.

[turnidge, 2011-11-07 23:35:19]

PTAL

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:464: DART_EXPORT Dart_Handle
Dart_ToString(Dart_Handle object);
On 2011/11/07 23:10:45, Ivan Posva wrote:
> Dart_ToString and Dart_IsSame are functions that should apply to all kinds of
> handles. We should probably move them out of the // --- Objects --- area.

Moved.

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:479: DART_EXPORT Dart_Handle Dart_Equals(Dart_Handle
obj1,
On 2011/11/07 23:10:45, Ivan Posva wrote:
> This should really be Dart_ObjectEquals to be consistent with other typed API.

Done.

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:496: DART_EXPORT Dart_Handle
Dart_TripleEquals(Dart_Handle obj1,
On 2011/11/07 23:10:45, Ivan Posva wrote:
> Dart_IsSame as discussed offline.

Done.

http://codereview.chromium.org/8490016/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:512: DART_EXPORT Dart_Handle Dart_IsType(Dart_Handle
object,
On 2011/11/07 23:10:45, Ivan Posva wrote:
> Dart_ObjectIsType, again to be consistent.

Done.

[Ivan Posva, 2011-11-07 23:48:29]

LGTM with comments.

-Ivan

http://codereview.chromium.org/8490016/diff/4002/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8490016/diff/4002/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:148: * The result of the comparison is returned
through the 'identical'
identical -> same

http://codereview.chromium.org/8490016/diff/4002/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:154: * \param equal Returns the result of the
equality comparison.
equal -> same

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:515: DART_EXPORT Dart_Handle Dart_IsSame(Dart_Handle
obj1, Dart_Handle obj2,
I am wondering whether this function should just return a bool instead.

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:52: EXPECT(!identical);
Can you also test with objects that are not subclassed from the Instance class?

[turnidge, 2011-11-10 20:30:57]

Forgot to mail out these responses...

http://codereview.chromium.org/8490016/diff/4002/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8490016/diff/4002/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:148: * The result of the comparison is returned
through the 'identical'
On 2011/11/07 23:48:30, Ivan Posva wrote:
> identical -> same

Done.

http://codereview.chromium.org/8490016/diff/4002/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:154: * \param equal Returns the result of the
equality comparison.
On 2011/11/07 23:48:30, Ivan Posva wrote:
> equal -> same

Done.

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:515: DART_EXPORT Dart_Handle Dart_IsSame(Dart_Handle
obj1, Dart_Handle obj2,
On 2011/11/07 23:48:30, Ivan Posva wrote:
> I am wondering whether this function should just return a bool instead.

We have been discussing returning an error handle when there is no current
isolate.  In that case, this function will need an error return.  But I am
actually pretty torn about whether we should check for that error case or not --
it's pretty egregious to have no current isolate, so crashing might be
acceptable.

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/8490016/diff/4002/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:52: EXPECT(!identical);
On 2011/11/07 23:48:30, Ivan Posva wrote:
> Can you also test with objects that are not subclassed from the Instance
class?

Ok.

[Ivan Posva, 2011-11-10 21:43:45]

Sorry, it seems that my comment was not clear.

Still LGTM.

-Ivan

http://codereview.chromium.org/8490016/diff/10004/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8490016/diff/10004/runtime/include/dart_api.h#...
runtime/include/dart_api.h:150: * \param equal Returns whether the two objects
are the same.
equal -> same for the parameter name.