Renaming:

runtime/include/dart_api.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef INCLUDE_DART_API_H_
 #define INCLUDE_DART_API_H_
 
 /** \mainpage Dart Embedding API Reference
  *
  * Dart is a class-based programming language for creating structured
@@ skipping 443 matching lines @@
 /**
  * Converts an object to a string.
  *
  * If an exception occurs during the conversion, this is treated as an
  * error.
  *
  * \return A handle to the converted string if no errors occur during
  * the conversion. If an error does occur, an invalid handle is
  * returned.
  */
-DART_EXPORT Dart_Handle Dart_ObjectToString(Dart_Handle object);
-// TODO(turnidge): Consider shortening name to Dart_ToString.
+DART_EXPORT Dart_Handle Dart_ToString(Dart_Handle object);

[Ivan Posva, 2011/11/07 23:10:45]

Dart_ToString and Dart_IsSame are functions that should apply to all kinds of
handles. We should probably move them out of the // --- Objects --- area.

[turnidge, 2011/11/07 23:35:19]

Moved.

 
 /**
- * Returns true if the two objects are equal.
+ * Checks if the two objects are equal.
  *
  * The result of the comparison is returned through the 'equal'
  * parameter. The return value itself is used to indicate success or
  * failure, not equality.
  *
  * \param obj1 An object to be compared.
  * \param obj2 An object to be compared.
  * \param equal Returns the result of the equality comparison.
  *
  * \return A valid handle if no error occurs during the comparison.
  */
-DART_EXPORT Dart_Handle Dart_Objects_Equal(Dart_Handle obj1,
-                                           Dart_Handle obj2,
-                                           bool* equal);
-// TODO(turnidge): Consider renaming for consistency. Maybe just
-// Dart_Equals.
-// TODO(turnidge): Need to add identity equality function.
+DART_EXPORT Dart_Handle Dart_Equals(Dart_Handle obj1,

[Ivan Posva, 2011/11/07 23:10:45]

This should really be Dart_ObjectEquals to be consistent with other typed API.

[turnidge, 2011/11/07 23:35:19]

Done.

+                                    Dart_Handle obj2,
+                                    bool* equal);
+
+/**
+ * Checks if the two objects are the same object
+ *
+ * The result of the comparison is returned through the 'identical'
+ * parameter. The return value itself is used to indicate success or
+ * failure, not identity.
+ *
+ * \param obj1 An object to be compared.
+ * \param obj2 An object to be compared.
+ * \param equal Returns the result of the equality comparison.
+ *
+ * \return A valid handle if no error occurs during the comparison.
+ */
+DART_EXPORT Dart_Handle Dart_TripleEquals(Dart_Handle obj1,

[Ivan Posva, 2011/11/07 23:10:45]

Dart_IsSame as discussed offline.

[turnidge, 2011/11/07 23:35:19]

Done.

+                                          Dart_Handle obj2,
+                                          bool* identical);
 
 /**
  * Is this object an instance of some type?
  *
  * The result of the test is returned through the 'instanceif' parameter.
  * The return value itself is used to indicate success or failure.
  *
  * \param object An object.
  * \param type A type.
  * \param instanceof Return true if 'object' is an instance of type 'type'.
  *
  * \return A valid handle if no error occurs during the operation.
  */
-DART_EXPORT Dart_Handle Dart_IsInstanceOf(Dart_Handle object,
-                                          Dart_Handle type,
-                                          bool* instanceof);
+DART_EXPORT Dart_Handle Dart_IsType(Dart_Handle object,

[Ivan Posva, 2011/11/07 23:10:45]

Dart_ObjectIsType, again to be consistent.

[turnidge, 2011/11/07 23:35:19]

Done.

+                                    Dart_Handle type,
+                                    bool* instanceof);
 
 // --- Numbers ----
 
 /**
  * Is this object a Number?
  */
 DART_EXPORT bool Dart_IsNumber(Dart_Handle object);
 
 // --- Integers ----
 
@@ skipping 492 matching lines @@
  * Rethrows an exception.
  *
  * Rethrows an exception, unwinding all dart frames on the stack.  If
  * successful, this function does not return.  Note that this means
  * that the destructors of any stack-allocated C++ objects will not be
  * called.  If there are no Dart frames on the stack, an error occurs.
  *
  * \return An invalid handle if the exception was not thrown.
  *   Otherwise the function does not return.
  */
-DART_EXPORT Dart_Handle Dart_ReThrowException(Dart_Handle exception,
+DART_EXPORT Dart_Handle Dart_RethrowException(Dart_Handle exception,
                                               Dart_Handle stacktrace);
-// TODO(turnidge): ReThrow -> Rethrow.
 
 // --- Native functions ---
 
 /**
  * The arguments to a native function.
  *
  * This object is passed to a native function to represent its
  * arguments and return value. It allows access to the arguments to a
  * native function by index. It also allows the return value of a
  * native function to be set.
@@ skipping 108 matching lines @@
 
 // --- Profiling support ----
 
 // External pprof support for gathering and dumping symbolic
 // information that can be used for better profile reports for
 // dynamically generated code.
 DART_EXPORT void Dart_InitPprofSupport();
 DART_EXPORT void Dart_GetPprofSymbolInfo(void** buffer, int* buffer_size);
 
 #endif  // INCLUDE_DART_API_H_