Issue 8451002: Tweak shouldWarnOnNoSuchType() usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8451002: Tweak shouldWarnOnNoSuchType() usage. (Closed)

Created:
9 years, 1 month ago by scheglov

Modified:
9 years, 1 month ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Tweak shouldWarnOnNoSuchType() usage. R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1158

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -154 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	2 chunks	+0 lines, -12 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/DartCompilerMainContext.java	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java	View	1 chunk	+1 line, -1 line	0 comments	Download
D	compiler/javatests/com/google/dart/compiler/end2end/NonStrictResolutionTest.java	View	1 chunk	+0 lines, -111 lines	0 comments	Download
D	compiler/javatests/com/google/dart/compiler/end2end/NonStrictResolutionTests.java	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

9 years, 1 month ago (2011-11-03 16:39:36 UTC) #2

LGTM

http://codereview.chromium.org/8451002/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (right):

http://codereview.chromium.org/8451002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:116: usage =
"Write generated JavaSccript  to a file")
would you mind fixing JavaSccript --> JavaScript and removing the extra space in
this help description?

Expand Messages | Collapse Messages