Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: compiler/java/com/google/dart/compiler/DartCompilerMainContext.java

Issue 8451002: Tweak shouldWarnOnNoSuchType() usage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
diff --git a/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java b/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
index 106c583dad0c4d64e516de7642fd324979e0ab7a..0b7e97263d95525a815752f444ede4d1ece42dd5 100644
--- a/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
+++ b/compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
@@ -9,7 +9,6 @@ import com.google.dart.compiler.ast.LibraryUnit;
import com.google.dart.compiler.metrics.CompilerMetrics;
import com.google.dart.compiler.parser.DartParser;
import com.google.dart.compiler.resolver.ResolverErrorCode;
-import com.google.dart.compiler.resolver.TypeErrorCode;
import java.io.IOException;
import java.io.Reader;
@@ -51,14 +50,11 @@ final class DartCompilerMainContext extends DartCompilerListener implements
@Override
public void onError(DartCompilationError event) {
- if (event.getErrorCode().getSubSystem() == SubSystem.STATIC_TYPE
- && (!shouldWarnOnNoSuchType() || (
- (event.getErrorCode() != TypeErrorCode.CANNOT_BE_RESOLVED) &&
- (event.getErrorCode() != TypeErrorCode.NO_SUCH_TYPE) &&
- (event.getErrorCode() != TypeErrorCode.INTERFACE_HAS_NO_METHOD_NAMED)))) {
+ if (event.getErrorCode().getSubSystem() == SubSystem.STATIC_TYPE) {
incrementTypeErrorCount();
- } else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.ERROR &&
- (!shouldWarnOnNoSuchType() || event.getErrorCode() != ResolverErrorCode.NO_SUCH_TYPE)) {
+ } else if (shouldWarnOnNoSuchType() && event.getErrorCode() == ResolverErrorCode.NO_SUCH_TYPE) {
+ incrementTypeErrorCount();
+ } else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.ERROR) {
incrementErrorCount();
} else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.WARNING) {
incrementWarningCount();

Powered by Google App Engine
This is Rietveld 408576698