Two-phase constructors

Two-phase constructors

This CL fixes the initializer evaluation order and brings the VM fully up to spec.

Constructors are executed in two phases: the initializer phase and the constructor body phase. An additional implicit parameter tells the constructor code whether to execute the initializer list or the body (or both).

If the super initializer call is not at the end of the initializer list, the super constructor has to be called twice. The arguments to the super initializer have to be evaluated and stored in temporary local variables. At the beginning of the constructor block, a second implicit super call is inserted.

If the super initializer call happens to be at the end of the list, none of this madness has to happen, except for the extra implicit parameter to the constructor.

 
Committed: https://code.google.com/p/dart/source/detail?r=1102

[srdjan, 2011-11-02 00:08:13]

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1582: if (func.IsConstructor()) {
The if (func.IsConstructor()) is very long. Can you factor it out to a separate
method?

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1593: // constuctor's initializer list get compiled.
constructor's

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1685: if (func.IsConstructor()) {
Also a very  long if.

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:5981: GrowableArray<const Object*>
arg_values(arguments->length() + 2);
Please add comment about + 2

[srdjan, 2011-11-02 00:08:24]

LGTM as well.

[hausner, 2011-11-02 00:26:40]

Thank you!

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1582: if (func.IsConstructor()) {
On 2011/11/02 00:08:13, srdjan wrote:
> The if (func.IsConstructor()) is very long. Can you factor it out to a
separate
> method?

I am planning to separate the compilation of constructors and regular functions
in a subsequent change list.

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1593: // constuctor's initializer list get compiled.
On 2011/11/02 00:08:13, srdjan wrote:
> constructor's

Done.

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1685: if (func.IsConstructor()) {
On 2011/11/02 00:08:13, srdjan wrote:
> Also a very  long if.

see above.

http://codereview.chromium.org/8440014/diff/7001/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:5981: GrowableArray<const Object*>
arg_values(arguments->length() + 2);
On 2011/11/02 00:08:13, srdjan wrote:
> Please add comment about + 2

Done.