Two-phase constructors

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 2297 matching lines @@
   const ExternalLabel label(cls.ToCString(), stub.EntryPoint());
   GenerateCall(node->token_index(), &label);
   if (requires_type_arguments) {
     __ popl(ECX);  // Pop type arguments.
     __ popl(ECX);  // Pop instantiator type arguments.
   }
 
   if (IsResultNeeded(node)) {
     __ pushl(EAX);  // Set up return value from allocate.
   }
-  __ pushl(EAX);  // First argument(this) for constructor call which follows.
+
+  // First argument(this) for constructor call which follows.
+  __ pushl(EAX);
+  // Second argument is the implicit constructor phase parameter.
+  // Run both the constructor initializer list and the constructor body.
+  __ PushObject(Smi::ZoneHandle(Smi::New(Function::kCtorPhaseAll)));
+
 
   // Now setup rest of the arguments for the constructor call.
   node->arguments()->Visit(this);
 
   // Call the constructor.
-  int num_args = node->arguments()->length() + 1;  // +1 to include receiver.
+  // +2 to include implicit receiver and phase arguments.
+  int num_args = node->arguments()->length() + 2;
   __ LoadObject(ECX, node->constructor());
   __ LoadObject(EDX, ArgumentsDescriptor(num_args, node->arguments()->names()));
   GenerateCall(node->token_index(), &StubCode::CallStaticFunctionLabel());
   // Constructors do not return any value.
 
   // Pop out all the other arguments on the stack.
   __ addl(ESP, Immediate(num_args * kWordSize));
 }
 
 
@@ skipping 303 matching lines @@
   const Class& cls = Class::Handle(parsed_function_.function().owner());
   const Script& script = Script::Handle(cls.script());
   Parser::ReportMsg(script, token_index, "Error", error_msg, format, args);
   Isolate::Current()->long_jump_base()->Jump(1, error_msg);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32