Tweaks to get presubmit working

Tweaks to get presubmit working


R=zundel
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1035

[zundel, 2011-11-01 18:13:46]

lgtm

http://codereview.chromium.org/8439006/diff/1/tools/presubmit.sh
File tools/presubmit.sh (right):

http://codereview.chromium.org/8439006/diff/1/tools/presubmit.sh#newcode98
tools/presubmit.sh:98: doTest runtime arch ia32 debug
this doesn't seem right.  the component in this case is named "vm", then we can
either nail up the --arch parameter to ia32 inside of doTest, or omit it
entirely (that's what I'd prefer)

[zundel, 2011-11-01 18:14:16]

On 2011/11/01 18:13:46, zundel wrote:
> lgtm
> 
> http://codereview.chromium.org/8439006/diff/1/tools/presubmit.sh
> File tools/presubmit.sh (right):
> 
> http://codereview.chromium.org/8439006/diff/1/tools/presubmit.sh#newcode98
> tools/presubmit.sh:98: doTest runtime arch ia32 debug
> this doesn't seem right.  the component in this case is named "vm", then we
can
> either nail up the --arch parameter to ia32 inside of doTest, or omit it
> entirely (that's what I'd prefer)
(Sorry, I didn't mean to hit the LGTM button yet)

[codefu, 2011-11-01 18:15:14]

http://codereview.chromium.org/8439006/diff/1/tools/presubmit.sh
File tools/presubmit.sh (right):

http://codereview.chromium.org/8439006/diff/1/tools/presubmit.sh#newcode98
tools/presubmit.sh:98: doTest runtime arch ia32 debug
On 2011/11/01 18:13:47, zundel wrote:
> this doesn't seem right.  the component in this case is named "vm", then we
can
> either nail up the --arch parameter to ia32 inside of doTest, or omit it
> entirely (that's what I'd prefer)

I like that better than specifying the component on each line.

[codefu, 2011-11-01 18:21:11]

PTAL

http://codereview.chromium.org/8439006/diff/4001/tools/presubmit.sh
File tools/presubmit.sh (right):

http://codereview.chromium.org/8439006/diff/4001/tools/presubmit.sh#newcode48
tools/presubmit.sh:48: ./tools/test.py --component $2 --mode $3
Less change.

[zundel, 2011-11-01 18:22:59]

LGTM, for real this time.