Issue 8437048: Dart rewrite of test scripts: do not fail test on missing status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8437048: Dart rewrite of test scripts: do not fail test on missing status file. (Closed)

Created:
9 years, 1 month ago by Bill Hesse

Modified:
9 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Dart rewrite of test scripts: do not fail test on missing status file. BUG= TEST=standalone/StatusFileParserTest Committed: https://code.google.com/p/dart/source/detail?r=1077

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/testing/dart/status_file_parser.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

TBR=ager@google.com TEST=standalone/StatusFileParserTest

9 years, 1 month ago (2011-11-02 10:33:18 UTC) #1

Mads Ager (google)

9 years, 1 month ago (2011-11-02 10:47:34 UTC) #2

LGTM to get the buildbot green, but please fix the test instead.

http://codereview.chromium.org/8437048/diff/1/tools/testing/dart/status_file_...
File tools/testing/dart/status_file_parser.dart (right):

http://codereview.chromium.org/8437048/diff/1/tools/testing/dart/status_file_...
tools/testing/dart/status_file_parser.dart:33: if (!file.existsSync()) return; 
// TODO(whesse): Handle missing file.
This seems like the wrong fix. Please change the test instead to check that the
file exists before passing it into the parser.

Expand Messages | Collapse Messages