tools/testing/dart/status_file_parser.dart - Issue 8437048: Dart rewrite of test scripts: do not fail test on missing status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 8437048: Dart rewrite of test scripts: do not fail test on missing status file. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/status_file_parser.dart

diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart

index 3c1ae7c5c145cce13f0793e10a58228b07b379c4..d7a7345214ba3381667fa64ecf7a0bc30967bbdf 100644

--- a/tools/testing/dart/status_file_parser.dart

+++ b/tools/testing/dart/status_file_parser.dart

@@ -30,7 +30,7 @@ String getFilename(String path) =>

void ReadConfigurationInto(path, sections) {

File file = new File(getFilename(path));

- Expect.isTrue(file.existsSync()); // TODO(whesse): Handle missing file.

+ if (!file.existsSync()) return; // TODO(whesse): Handle missing file.

Mads Ager (google) 2011/11/02 10:47:34 This seems like the wrong fix. Please change the t

FileInputStream file_stream = file.openInputStream();

StringInputStream lines = new StringInputStream(file_stream);

« no previous file with comments | « no previous file | no next file » | no next file with comments »