Issue 8430028: Update to co19 revision 15.

Issue 8430028: Update to co19 revision 15. (Closed)

Created:
9 years, 1 month ago by ahe

Modified:
9 years, 1 month ago

Reviewers:
ngeoffray, kasperl, zundel

CC:
reviews_dartlang.org, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Update to co19 revision 15. Committed: https://code.google.com/p/dart/source/detail?r=1004

Patch Set 2 : Address review comments #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+512 lines, -100 lines)			Patch
M	dart/.gitignore	View		1 chunk	+2 lines, -0 lines	2 comments	Download
M	dart/tests/co19/co19-compiler.status	View	1	5 chunks	+274 lines, -15 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View	1	3 chunks	+199 lines, -72 lines	0 comments	Download
M	dart/tools/test.py	View	1	2 chunks	+22 lines, -1 line	0 comments	Download
M	dart/tools/testing/test_runner.py	View		1 chunk	+11 lines, -8 lines	0 comments	Download
M	deps/all.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	deps/compiler.deps/DEPS	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	deps/standalone.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

zundel

http://codereview.chromium.org/8430028/diff/1/dart/tests/co19/co19-compiler.status File dart/tests/co19/co19-compiler.status (right): http://codereview.chromium.org/8430028/diff/1/dart/tests/co19/co19-compiler.status#newcode434 dart/tests/co19/co19-compiler.status:434: [ $arch == dartc && $mode == debug ] ...

9 years, 1 month ago (2011-11-01 13:24:36 UTC) #3

zundel

On 2011/11/01 13:24:36, zundel wrote: > http://codereview.chromium.org/8430028/diff/1/dart/tests/co19/co19-compiler.status > File dart/tests/co19/co19-compiler.status (right): > > http://codereview.chromium.org/8430028/diff/1/dart/tests/co19/co19-compiler.status#newcode434 > ...

9 years, 1 month ago (2011-11-01 13:24:51 UTC) #4

ahe

Nice catch, Eric. Thanks for taking a look. Cheers, Peter http://codereview.chromium.org/8430028/diff/1/dart/tests/co19/co19-compiler.status File dart/tests/co19/co19-compiler.status (right): http://codereview.chromium.org/8430028/diff/1/dart/tests/co19/co19-compiler.status#newcode434 ...

9 years, 1 month ago (2011-11-01 13:29:00 UTC) #5

zundel

http://codereview.chromium.org/8430028/diff/5001/dart/.gitignore File dart/.gitignore (right): http://codereview.chromium.org/8430028/diff/5001/dart/.gitignore#newcode65 dart/.gitignore:65: /frog/ did you mean to check this in?

9 years, 1 month ago (2011-11-01 13:33:36 UTC) #7

ahe

9 years, 1 month ago (2011-11-01 13:42:06 UTC) #8

http://codereview.chromium.org/8430028/diff/5001/dart/.gitignore
File dart/.gitignore (right):

http://codereview.chromium.org/8430028/diff/5001/dart/.gitignore#newcode65
dart/.gitignore:65: /frog/
On 2011/11/01 13:33:36, zundel wrote:
> did you mean to check this in?

Yes. Frog is listed in all.deps, and should be ignored by git.

Expand Messages | Collapse Messages