Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2164)

Unified Diff: dart/tools/testing/test_runner.py

Issue 8430028: Update to co19 revision 15. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/.gitignore ('K') | « dart/tools/test.py ('k') | deps/all.deps/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/test_runner.py
diff --git a/dart/tools/testing/test_runner.py b/dart/tools/testing/test_runner.py
index 00bdf38ebb3c9230df0f28d0ab9bf937fdfd3ff4..9b2a6e0e121b8b678f5c8413a1cc8a4a4b46cc4e 100755
--- a/dart/tools/testing/test_runner.py
+++ b/dart/tools/testing/test_runner.py
@@ -62,15 +62,18 @@ class TestOutput(object):
Returns:
True if the test had an unexpected output.
"""
+ return not self.GetOutcome() in self.test.outcomes
+
+ def GetOutcome(self):
+ """Returns one of testing.CRASH, testing.TIMEOUT, testing.FAIL, or
+ testing.PASS."""
if self.HasCrashed():
- outcome = testing.CRASH
- elif self.HasTimedOut():
- outcome = testing.TIMEOUT
- elif self.HasFailed():
- outcome = testing.FAIL
- else:
- outcome = testing.PASS
- return not outcome in self.test.outcomes
+ return testing.CRASH
+ if self.HasTimedOut():
+ return testing.TIMEOUT
+ if self.HasFailed():
+ return testing.FAIL
+ return testing.PASS
def HasCrashed(self):
"""Returns True if the test should be considered testing.CRASH."""
« dart/.gitignore ('K') | « dart/tools/test.py ('k') | deps/all.deps/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698