Issue 8417023: Add type checks to directory listing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8417023: Add type checks to directory listing. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Add type checks to directory listing. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=940

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -45 lines)			Patch
M	runtime/bin/directory.cc	View	3 chunks	+40 lines, -24 lines	0 comments	Download
M	runtime/bin/directory.dart	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/bin/directory_impl.dart	View	3 chunks	+18 lines, -19 lines	2 comments	Download
A	tests/standalone/src/DirectoryInvalidArgumentsTest.dart	View	1 chunk	+42 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/8417023/diff/1/runtime/bin/directory_impl.dart File runtime/bin/directory_impl.dart (right): http://codereview.chromium.org/8417023/diff/1/runtime/bin/directory_impl.dart#newcode113 runtime/bin/directory_impl.dart:113: _closePort(filePort); Shouldn't the error port be closed if ...

9 years, 1 month ago (2011-10-28 13:05:55 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-10-28 15:58:16 UTC) #3

http://codereview.chromium.org/8417023/diff/1/runtime/bin/directory_impl.dart
File runtime/bin/directory_impl.dart (right):

http://codereview.chromium.org/8417023/diff/1/runtime/bin/directory_impl.dart...
runtime/bin/directory_impl.dart:113: _closePort(filePort);
On 2011/10/28 13:05:55, Søren Gjesse wrote:
> Shouldn't the error port be closed if everything ends normally?

It is on line 109. If listing does not start the single shot error and done
ports are signaled which will close them. Otherwise they will be closed
explicitly in the else branch.

Expand Messages | Collapse Messages