Add type checks to directory listing.

runtime/bin/directory_impl.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
-class DirectoryException {
-  String toString() { return "DirectoryException: $message"; }
-  const DirectoryException(String this.message);
-  final String message;
-}
-
-
 class _DirectoryListingIsolate extends Isolate {
 
   _DirectoryListingIsolate() : super.heavy();
 
   void main() {
     port.receive((message, replyTo) {
-       _list(message['dir'],
-             message['recursive'],
-             message['dirPort'],
-             message['filePort'],
-             message['donePort'],
-             message['errorPort']);
-       replyTo.send(true);
+      bool started = _list(message['dir'],
+                           message['recursive'],
+                           message['dirPort'],
+                           message['filePort'],
+                           message['donePort'],
+                           message['errorPort']);
+      replyTo.send(started);
     });
   }
 
-  void _list(String dir,
+  bool _list(String dir,
              bool recursive,
              SendPort dirPort,
              SendPort filePort,
              SendPort donePort,
              SendPort errorPort) native "Directory_List";
 }
 
 
 class _Directory implements Directory {
 
@@ skipping 44 matching lines @@
         listingParameters['dirPort'] = dirPort.toSendPort();
       }
       if (_fileHandler !== null) {
         filePort = new ReceivePort();
         filePort.receive((String file, ignored) {
           _fileHandler(file);
         });
         listingParameters['filePort'] = filePort.toSendPort();
       }
       if (_doneHandler !== null) {
-        donePort = new ReceivePort();
+        donePort = new ReceivePort.singleShot();
         donePort.receive((bool completed, ignored) {
           _doneHandler(completed);
         });
         listingParameters['donePort'] = donePort.toSendPort();
       }
       if (_errorHandler !== null) {
-        errorPort = new ReceivePort();
+        errorPort = new ReceivePort.singleShot();
         errorPort.receive((String error, ignored) {
           _errorHandler(error);
         });
         listingParameters['errorPort'] = errorPort.toSendPort();
       }
 
       // Close ports when listing is done.
       ReceivePort closePortsPort = new ReceivePort();
       closePortsPort.receive((message, replyTo) {
+        if (!message) {
+          errorPort.toSendPort().send(
+              "Failed to list directory: $_path recursive: $recursive");
+          donePort.toSendPort().send(false);
+        } else {
+          _closePort(errorPort);
+          _closePort(donePort);
+        }
         _closePort(dirPort);
         _closePort(filePort);

[Søren Gjesse, 2011/10/28 13:05:55]

Shouldn't the error port be closed if everything ends normally?

[Mads Ager (google), 2011/10/28 15:58:16]

It is on line 109. If listing does not start the single shot error and done
ports are signaled which will close them. Otherwise they will be closed
explicitly in the else branch.

-        _closePort(donePort);
-        _closePort(errorPort);
         _closePort(closePortsPort);
       });
 
       // Send the listing parameters to the isolate.
       port.send(listingParameters, closePortsPort.toSendPort());
     });
   }
 
   void setDirHandler(void dirHandler(String dir)) {
     _dirHandler = dirHandler;
@@ skipping 23 matching lines @@
   bool _create(String path) native "Directory_Create";
   bool _delete(String path) native "Directory_Delete";
 
   var _dirHandler;
   var _fileHandler;
   var _doneHandler;
   var _errorHandler;
 
   String _path;
 }