Verify that user classes/interfaces do not extend/implement any of bool, num,

Verify that user classes/interfaces do not extend/implement any of bool, num,
int, double, String, Function, or Dynamic.
Committed: https://code.google.com/p/dart/source/detail?r=922

[srdjan, 2011-10-28 21:42:42]

LGTM 

Could you also "fix" the  BlackListedTest in /tests/standalone/standalone.status
?

http://codereview.chromium.org/8416052/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

http://codereview.chromium.org/8416052/diff/1/runtime/vm/class_finalizer.cc#n...
runtime/vm/class_finalizer.cc:912: (interface.IsFunctionInterface() &&
!cls.IsSignatureClass())||
Add space before ||

http://codereview.chromium.org/8416052/diff/1/runtime/vm/class_finalizer.cc#n...
runtime/vm/class_finalizer.cc:918: }
We need also to check for Smi, Double, etc classes. If users attempt to subclass
them the VM will crash.

[regis, 2011-10-28 22:23:58]

Thanks!

I also "fixed" the BlackListedTest in /tests/standalone/standalone.status

-- Regis

http://codereview.chromium.org/8416052/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

http://codereview.chromium.org/8416052/diff/1/runtime/vm/class_finalizer.cc#n...
runtime/vm/class_finalizer.cc:912: (interface.IsFunctionInterface() &&
!cls.IsSignatureClass())||
On 2011/10/28 21:42:42, srdjan wrote:
> Add space before ||

Done.

http://codereview.chromium.org/8416052/diff/1/runtime/vm/class_finalizer.cc#n...
runtime/vm/class_finalizer.cc:918: }
On 2011/10/28 21:42:42, srdjan wrote:
> We need also to check for Smi, Double, etc classes. If users attempt to
subclass
> them the VM will crash.

Good point! Since these are classes rather than interfaces, I need to check
elsewhere. I have added a TODO and will do it in a later cl.

[Anton Muhin, 2011-10-31 08:28:29]

DBQ

http://codereview.chromium.org/8416052/diff/3003/tests/language/src/BlackList...
File tests/language/src/BlackListedTest.dart (right):

http://codereview.chromium.org/8416052/diff/3003/tests/language/src/BlackList...
tests/language/src/BlackListedTest.dart:34: class MyDynamic implements Dynamic
{}            /// 13: compile-time error
just for my education, will this test pass if any of those declarations is
invalid or only if all of them?

[srdjan, 2011-10-31 15:18:26]

http://codereview.chromium.org/8416052/diff/3003/tests/language/src/BlackList...
File tests/language/src/BlackListedTest.dart (right):

http://codereview.chromium.org/8416052/diff/3003/tests/language/src/BlackList...
tests/language/src/BlackListedTest.dart:34: class MyDynamic implements Dynamic
{}            /// 13: compile-time error
On 2011/10/31 08:28:29, antonmuhin wrote:
> just for my education, will this test pass if any of those declarations is
> invalid or only if all of them?

This test is split in 13 different tests/files automagically and they will be
tested (or fail) independently.

[Anton Muhin, 2011-10-31 15:20:27]

http://codereview.chromium.org/8416052/diff/3003/tests/language/src/BlackList...
File tests/language/src/BlackListedTest.dart (right):

http://codereview.chromium.org/8416052/diff/3003/tests/language/src/BlackList...
tests/language/src/BlackListedTest.dart:34: class MyDynamic implements Dynamic
{}            /// 13: compile-time error
Thanks a lot for explanations, Srdjan.

On 2011/10/31 15:18:26, srdjan wrote:
> On 2011/10/31 08:28:29, antonmuhin wrote:
> > just for my education, will this test pass if any of those declarations is
> > invalid or only if all of them?
> 
> This test is split in 13 different tests/files automagically and they will be
> tested (or fail) independently.