Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8416052: Verify that user classes/interfaces do not extend/implement any of bool, num, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 921)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -1647,10 +1647,7 @@
Immediate(reinterpret_cast<int32_t>(Smi::New(token_index)));
__ pushl(location); // Push the source location.
__ pushl(EAX); // Push the source object.
- // TODO(regis): Once we enforce the rule prohibiting subtyping of bool, we
- // should rename the runtime call 'ConditionTypeCheck' to
- // 'ConditionTypeError'.
- GenerateCallRuntime(token_index, kConditionTypeCheckRuntimeEntry);
+ GenerateCallRuntime(token_index, kConditionTypeErrorRuntimeEntry);
// Pop the parameters supplied to the runtime entry. The result of the
// type check runtime call is the checked value.
__ addl(ESP, Immediate(3 * kWordSize));

Powered by Google App Engine
This is Rietveld 408576698