New OutputStream interface

New OutputStream interface

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=997

[Søren Gjesse, 2011-10-28 12:49:25]

http://codereview.chromium.org/8413034/diff/1/runtime/bin/socket_stream.dart
File runtime/bin/socket_stream.dart (right):

http://codereview.chromium.org/8413034/diff/1/runtime/bin/socket_stream.dart#...
runtime/bin/socket_stream.dart:59: class _BufferList2 {
This is quite similar to the BufferList class used for UFT8 decoding in the
StringInputStream. I will merge the two in a separate change.

[Mads Ager (google), 2011-10-31 09:56:48]

LGTM

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.dart
File runtime/bin/output_stream.dart (right):

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:24: * the data is buffered by the output stream
and will be send as
will be sent

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:37: * stream and will be send as soon as
possible.
will be sent

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:43: * stream. When all data has been written to
communication channel
to communication -> to the communication

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:64: * channel have been closed.
have -> has

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:72: void set errorHandler(void callback());
Should the callback take a string or some other error indication? We don't have
to add that now.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:114: // Don't throw exceptions when closing sockets
more than once.
Maybe remove this here and add it is a comment to the interface instead?

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.dart
File runtime/bin/socket_stream.dart (right):

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:91: bool get empty() => _buffers.isEmpty();
I don't think empty should be a getter. I would only use getters for stuff that
is logically a field.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:107: :  _socket = socket, _pendingWrites = new
_BufferList2() {
Are there two spaces between ":" and "_" here?

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:109: _socket.setErrorHandler(_errorHandler);
Indentation.

[Søren Gjesse, 2011-11-01 08:56:46]

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.dart
File runtime/bin/output_stream.dart (right):

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:24: * the data is buffered by the output stream
and will be send as
On 2011/10/31 09:56:48, Mads Ager wrote:
> will be sent

Done.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:37: * stream and will be send as soon as
possible.
On 2011/10/31 09:56:48, Mads Ager wrote:
> will be sent

Done.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:43: * stream. When all data has been written to
communication channel
On 2011/10/31 09:56:48, Mads Ager wrote:
> to communication -> to the communication

Done.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:64: * channel have been closed.
On 2011/10/31 09:56:48, Mads Ager wrote:
> have -> has

Done.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/output_stream.da...
runtime/bin/output_stream.dart:72: void set errorHandler(void callback());
On 2011/10/31 09:56:48, Mads Ager wrote:
> Should the callback take a string or some other error indication? We don't
have
> to add that now.

Maybe this should be an exception object. We will determine later.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_impl.dart...
runtime/bin/socket_impl.dart:114: // Don't throw exceptions when closing sockets
more than once.
On 2011/10/31 09:56:48, Mads Ager wrote:
> Maybe remove this here and add it is a comment to the interface instead?

Done.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.dart
File runtime/bin/socket_stream.dart (right):

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:91: bool get empty() => _buffers.isEmpty();
On 2011/10/31 09:56:48, Mads Ager wrote:
> I don't think empty should be a getter. I would only use getters for stuff
that
> is logically a field. 

Done.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:107: :  _socket = socket, _pendingWrites = new
_BufferList2() {
On 2011/10/31 09:56:48, Mads Ager wrote:
> Are there two spaces between ":" and "_" here?

Done.

http://codereview.chromium.org/8413034/diff/3001/runtime/bin/socket_stream.da...
runtime/bin/socket_stream.dart:109: _socket.setErrorHandler(_errorHandler);
On 2011/10/31 09:56:48, Mads Ager wrote:
> Indentation.

Done.