Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: tests/standalone/src/SocketExceptionTest.dart

Issue 8413034: New OutputStream interface (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments from ager@ Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/ProcessStdoutTest.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/SocketExceptionTest.dart
diff --git a/tests/standalone/src/SocketExceptionTest.dart b/tests/standalone/src/SocketExceptionTest.dart
index 854db315477def8895ba2a99a5746fc79b3b97a0..8ee11fce977574f0e8c464ce0d1d649e3be9f0f1 100644
--- a/tests/standalone/src/SocketExceptionTest.dart
+++ b/tests/standalone/src/SocketExceptionTest.dart
@@ -23,7 +23,7 @@ class SocketExceptionTest {
} catch (Exception ex) {
wrongExceptionCaught = true;
}
- Expect.equals(true, exceptionCaught);
+ Expect.equals(false, exceptionCaught);
Expect.equals(true, !wrongExceptionCaught);
exceptionCaught = false;
try {
@@ -56,7 +56,7 @@ class SocketExceptionTest {
} catch (Exception ex) {
wrongExceptionCaught = true;
}
- Expect.equals(true, exceptionCaught);
+ Expect.equals(false, exceptionCaught);
Expect.equals(true, !wrongExceptionCaught);
exceptionCaught = false;
try {
@@ -104,7 +104,7 @@ class SocketExceptionTest {
exceptionCaught = false;
try {
List<int> buffer = new List<int>(42);
- bool readDone = output.write(buffer, 0, 12, null);
+ output.writeFrom(buffer, 0, 12);
} catch (SocketIOException ex) {
exceptionCaught = true;
} catch (Exception ex) {
« no previous file with comments | « tests/standalone/src/ProcessStdoutTest.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698