Add constructors to all the event classes.

Add constructors to all the event classes.

Committed: https://code.google.com/p/dart/source/detail?r=914

[Jacob, 2011-10-27 21:23:05]

Looks good overall.
You'll also need to correct all existing uses of init\w+Event in the client code
before committing.

http://codereview.chromium.org/8404013/diff/1/client/html/src/AnimationEventW...
File client/html/src/AnimationEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/AnimationEventW...
client/html/src/AnimationEventWrappingImplementation.dart:8:
AnimationEventWrappingImplementation._wrap(ptr) : super._wrap(ptr) {}
these are flaws in the generated code but if you want, cleanup the dart syntax a
bit.
E.g. remove the empty {}

change String get animationName() {.... } 
to 
String get animationName => _ptr.animationName;

etc

http://codereview.chromium.org/8404013/diff/1/client/html/src/BeforeLoadEvent...
File client/html/src/BeforeLoadEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/BeforeLoadEvent...
client/html/src/BeforeLoadEventWrappingImplementation.dart:8: factory
BeforeLoadEventWrappingImplementation(String type, String url,
I like that canBubble and cancelable are now always the last args.

http://codereview.chromium.org/8404013/diff/1/client/html/src/DeviceMotionEve...
File client/html/src/DeviceMotionEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/DeviceMotionEve...
client/html/src/DeviceMotionEventWrappingImplementation.dart:11:
e.initEvent(type, canBubble, cancelable);
add a TODO that DeviceMotionEvent should in the future have a constructor with
more args when Dart's support of it is more complete.

http://codereview.chromium.org/8404013/diff/1/client/html/src/MouseEventWrapp...
File client/html/src/MouseEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/MouseEventWrapp...
client/html/src/MouseEventWrappingImplementation.dart:13: var e =
dom.document.createEvent("MouseEvent");
use final instead of var here and elsewhere

http://codereview.chromium.org/8404013/diff/1/client/tests/client/html/EventT...
File client/tests/client/html/EventTests.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/tests/client/html/EventT...
client/tests/client/html/EventTests.dart:6: test('AnimationEvent', () {
suggested additional tests:
make sure that some of the events can actually be dispatched

[nweiz, 2011-10-27 22:23:54]

http://codereview.chromium.org/8404013/diff/1/client/html/src/AnimationEventW...
File client/html/src/AnimationEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/AnimationEventW...
client/html/src/AnimationEventWrappingImplementation.dart:8:
AnimationEventWrappingImplementation._wrap(ptr) : super._wrap(ptr) {}
On 2011/10/27 21:23:05, jacobr wrote:
> these are flaws in the generated code but if you want, cleanup the dart syntax
a
> bit.
> E.g. remove the empty {}
> 
> change String get animationName() {.... } 
> to 
> String get animationName => _ptr.animationName;
> 
> etc

Done.

http://codereview.chromium.org/8404013/diff/1/client/html/src/BeforeLoadEvent...
File client/html/src/BeforeLoadEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/BeforeLoadEvent...
client/html/src/BeforeLoadEventWrappingImplementation.dart:8: factory
BeforeLoadEventWrappingImplementation(String type, String url,
On 2011/10/27 21:23:05, jacobr wrote:
> I like that canBubble and cancelable are now always the last args.

Well, they aren't, strictly; they're after all the required args, since they're
optional, but if a function had other args that could be optional I put those
after canBubble and cancelable. I could change it to make them always the last
args if you think that's cleaner.

http://codereview.chromium.org/8404013/diff/1/client/html/src/DeviceMotionEve...
File client/html/src/DeviceMotionEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/DeviceMotionEve...
client/html/src/DeviceMotionEventWrappingImplementation.dart:11:
e.initEvent(type, canBubble, cancelable);
On 2011/10/27 21:23:05, jacobr wrote:
> add a TODO that DeviceMotionEvent should in the future have a constructor with
> more args when Dart's support of it is more complete.

Done (in the interface).

http://codereview.chromium.org/8404013/diff/1/client/html/src/MouseEventWrapp...
File client/html/src/MouseEventWrappingImplementation.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/html/src/MouseEventWrapp...
client/html/src/MouseEventWrappingImplementation.dart:13: var e =
dom.document.createEvent("MouseEvent");
On 2011/10/27 21:23:05, jacobr wrote:
> use final instead of var here and elsewhere

Done.

http://codereview.chromium.org/8404013/diff/1/client/tests/client/html/EventT...
File client/tests/client/html/EventTests.dart (right):

http://codereview.chromium.org/8404013/diff/1/client/tests/client/html/EventT...
client/tests/client/html/EventTests.dart:6: test('AnimationEvent', () {
On 2011/10/27 21:23:05, jacobr wrote:
> suggested additional tests:
> make sure that some of the events can actually be dispatched

Done. I figured out a moderately nice way of testing that each event type can be
dispatched.

[Jacob, 2011-10-27 22:37:54]

Same issue as previous CL.  the manual swap back from dart:html to
../../html.dart is included in the cl.
please re-upload without that issue.
aside from that it looks good although its hard to see whether all the client
sample code is updated to use new Event constructors due to the spurious files.

[Jacob, 2011-10-27 23:16:05]

http://codereview.chromium.org/8404013/diff/8127/client/touch/EventUtil.dart
File client/touch/EventUtil.dart (right):

http://codereview.chromium.org/8404013/diff/8127/client/touch/EventUtil.dart#...
client/touch/EventUtil.dart:29: static Event createEvent(String eventType) =>
take this a step further and kill off this now useless
EventUtil.createEvent function

http://codereview.chromium.org/8404013/diff/8127/client/touch/TouchUtil.dart
File client/touch/TouchUtil.dart (left):

http://codereview.chromium.org/8404013/diff/8127/client/touch/TouchUtil.dart#...
client/touch/TouchUtil.dart:254: void initTouchEvent(TouchList touches,
TouchList targetTouches,
nice... removing the ugly initXXXEvent methods had the unintended consequence of
making creating mock events a bit less painful.

[nweiz, 2011-10-27 23:47:23]

http://codereview.chromium.org/8404013/diff/8127/client/touch/EventUtil.dart
File client/touch/EventUtil.dart (right):

http://codereview.chromium.org/8404013/diff/8127/client/touch/EventUtil.dart#...
client/touch/EventUtil.dart:29: static Event createEvent(String eventType) =>
On 2011/10/27 23:16:05, jacobr wrote:
> take this a step further and kill off this now useless
> EventUtil.createEvent function

Done.

[jacob314, 2011-10-28 04:34:05]

lgtm