First round of changes to the file interface.

First round of changes to the file interface.

Have both async and sync version for the file operations. The
thinking is that once you have used an async operation you will
not be allowed to use a sync one. Only sync versions currently
implemented.

Instead of having one input and one output stream associated with a
file we create new streams whenever needed. These get their own
underlying file descriptor so they do not interfere. This means
that FileStreams have to be explicitly closed.

R=sgjesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=819

[Søren Gjesse, 2011-10-27 13:07:50]

lgtm

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart
File runtime/bin/file.dart (right):

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode39
runtime/bin/file.dart:39: void open([bool writable]);
[bool writable] -> [bool writable = false]

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode46
runtime/bin/file.dart:46: void openSync([bool writable]);
Ditto.

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode104
runtime/bin/file.dart:104: * Synchronously write a List<int> to the file. If the
list cannot be
Replace "If the list..." with !Returns true if the list was successfully written
and false otherwise."

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode115
runtime/bin/file.dart:115: void writeString(String string);
Shouldn't this have an encoding?

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode121
runtime/bin/file.dart:121: bool writeStringSync(String string);
Ditto.

[Mads Ager (google), 2011-10-27 13:21:46]

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart
File runtime/bin/file.dart (right):

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode39
runtime/bin/file.dart:39: void open([bool writable]);
On 2011/10/27 13:07:50, Søren Gjesse wrote:
> [bool writable] -> [bool writable = false]

You can only supply the default when you implement it.

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode46
runtime/bin/file.dart:46: void openSync([bool writable]);
On 2011/10/27 13:07:50, Søren Gjesse wrote:
> Ditto.

Same, can only supply the default value when you implement it.

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode104
runtime/bin/file.dart:104: * Synchronously write a List<int> to the file. If the
list cannot be
On 2011/10/27 13:07:50, Søren Gjesse wrote:
> Replace "If the list..." with !Returns true if the list was successfully
written
> and false otherwise."

Thanks! Done.

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode115
runtime/bin/file.dart:115: void writeString(String string);
On 2011/10/27 13:07:50, Søren Gjesse wrote:
> Shouldn't this have an encoding?

Yes, it should. I'll add a TODO and address it in a separate changelist.

http://codereview.chromium.org/8399033/diff/1/runtime/bin/file.dart#newcode121
runtime/bin/file.dart:121: bool writeStringSync(String string);
On 2011/10/27 13:07:50, Søren Gjesse wrote:
> Ditto.

Yes, I'll add a TODO.