Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1655)

Unified Diff: runtime/bin/builtin_in.cc

Issue 8399033: First round of changes to the file interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin_in.cc
diff --git a/runtime/bin/builtin_in.cc b/runtime/bin/builtin_in.cc
index 939441f6bac538b07eda0305ccabb899ccb85dec..28aac214d0eabcadfaa6ccdf31d598af6c409c5a 100644
--- a/runtime/bin/builtin_in.cc
+++ b/runtime/bin/builtin_in.cc
@@ -28,7 +28,7 @@ static const char Builtin_source_[] = {
V(Directory_Create, 2) \
V(Directory_Delete, 2) \
V(File_OpenFile, 3) \
- V(File_Exists, 1) \
+ V(File_Exists, 2) \
V(File_Close, 1) \
V(File_ReadByte, 1) \
V(File_WriteByte, 2) \
@@ -113,18 +113,10 @@ void Builtin_LoadLibrary() {
result = Dart_LibraryImportLibrary(builtin_lib, coreimpl_lib);
ASSERT(Dart_IsValid(result));
- // Create a native wrapper "FileNativeWrapper" so that we can add a
- // native field to store the OS file handle for implementing all the
- // file operations. The class "File" extends "FileNativeWrapper".
- Dart_Handle name = Dart_NewString("FileNativeWrapper");
- const int kNumFileFields = 1;
- result = Dart_CreateNativeWrapperClass(builtin_lib, name, kNumFileFields);
- ASSERT(Dart_IsValid(result));
-
// Create a native wrapper "EventHandlerNativeWrapper" so that we can add a
// native field to store the event handle for implementing all
// event operations.
- name = Dart_NewString("EventHandlerNativeWrapper");
+ Dart_Handle name = Dart_NewString("EventHandlerNativeWrapper");
const int kNumEventHandlerFields = 1;
result = Dart_CreateNativeWrapperClass(builtin_lib,
name,
« no previous file with comments | « no previous file | runtime/bin/file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698