Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 8383037: Improve error handling in the process library. (Closed)

Created:
9 years, 2 months ago by Mads Ager (google)
Modified:
9 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Improve error handling in the process library. Verify that the arguments have the types expected by the implementation. Require a List instance containing builtin Strings as the arguments. Require a builtin String path. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -82 lines) Patch
M runtime/bin/builtin_in.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M runtime/bin/dartutils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/file.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/file_linux.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M runtime/bin/file_macos.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/file_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/process.cc View 2 chunks +28 lines, -3 lines 0 comments Download
M runtime/bin/process.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/process_impl.dart View 1 chunk +15 lines, -5 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_script.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/process_script.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/socket.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A tests/standalone/src/ProcessInvalidArgumentsTest.dart View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
This change looks much bigger than it is. It changes all assert occurrences to ASSERT ...
9 years, 2 months ago (2011-10-25 11:18:42 UTC) #1
Søren Gjesse
lgtm I guess we need to something like this in other places where we pass ...
9 years, 2 months ago (2011-10-25 11:32:51 UTC) #2
Mads Ager (google)
9 years, 2 months ago (2011-10-25 11:33:28 UTC) #3
Yes, we do need to do that in other places. I'm on it. :-)

Powered by Google App Engine
This is Rietveld 408576698