Improve error handling in the process library.

runtime/bin/eventhandler_macos.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <errno.h>
 #include <poll.h>
 #include <pthread.h>
 #include <stdio.h>
 #include <string.h>
 #include <sys/time.h>
@@ skipping 42 matching lines @@
   free(port_map_);
   close(interrupt_fds_[0]);
   close(interrupt_fds_[1]);
 }
 
 
 // TODO(hpayer): Use hash table instead of array.
 void EventHandlerImplementation::SetPort(intptr_t fd,
                                  Dart_Port dart_port,
                                  intptr_t mask) {
-  assert(fd >= 0);
+  ASSERT(fd >= 0);
   if (fd >= port_map_size_) {
     intptr_t new_port_map_size = port_map_size_;
     do {
       new_port_map_size = new_port_map_size * kPortMapGrowingFactor;
     } while (fd >= new_port_map_size);
     size_t new_port_map_bytes = new_port_map_size * sizeof(PortData);
     port_map_ = reinterpret_cast<PortData*>(realloc(port_map_,
                                                     new_port_map_bytes));
     ASSERT(port_map_ != NULL);
     size_t port_map_bytes = port_map_size_ * sizeof(PortData);
@@ skipping 173 matching lines @@
   if (result_size > 0) {
     for (int i = 1; i < pollfds_size; i++) {
      /*
       * The fd is unregistered. It gets re-registered when the request
       * was handled by dart.
       */
       intptr_t event_mask = GetPollEvents(&pollfds[i]);
       if (event_mask != 0) {
         intptr_t fd = pollfds[i].fd;
         Dart_Port port = PortFor(fd);
-        assert(port != 0);
+        ASSERT(port != 0);
         UnregisterFd(fd);
         Dart_PostIntArray(port, 1, &event_mask);
       }
     }
   }
   HandleInterruptFd();
 }
 
 
 intptr_t EventHandlerImplementation::GetTimeout() {
@@ skipping 48 matching lines @@
     FATAL("Create start event handler thread");
   }
 }
 
 
 void EventHandlerImplementation::SendData(intptr_t id,
                                           Dart_Port dart_port,
                                           intptr_t data) {
   RegisterFdWakeup(id, dart_port, data);
 }