Refactor the dart api a bit:

Refactor the dart api a bit:

- Dart_Result is gone.  Dart_Handle mostly replaces it.
- Name/signature changes
  - IsValidResult -> IsValid
  - GetErrorCString -> GetError
  - many more...
- Make details of persistent handle freelist private.
- Add persistent "True" handle to api state.

Things I am not doing in this changelist:

- Documentation updates
Committed: https://code.google.com/p/dart/source/detail?r=778

[turnidge, 2011-10-24 21:37:43]

Ivan,

Please take a look.

Anton,

This change will effect you, so I wanted you to be aware of it.

Todd

[Anton Muhin, 2011-10-25 11:35:17]

Todd, thanks a lot for keeping in the loop.

I only glanced through dart_api.h changes and they look ok to me.  When the CL
is in a better shape, please, let me know and I'll prepare for its land.

[Ivan Posva, 2011-10-25 21:50:53]

LGTM after resolving the inconsistency.

-Ivan

http://codereview.chromium.org/8380020/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8380020/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:229: intptr_t* used);
Not sure if it makes it easier to use this way:

Dart_Handle Dart_StringGet8(Dart_Handle str, uint8_t* codepoints, intptr_t*
length);

var used = length;
result = Dart_StringGet8(str, buffer, &used);

http://codereview.chromium.org/8380020/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:264: DART_EXPORT Dart_Handle
Dart_ClosureSmrck(Dart_Handle object);
This does not match the result type in dart_api_impl.cc.

http://codereview.chromium.org/8380020/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8380020/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:785: "Object is not a String");
Weird alignment here and similar places.

[turnidge, 2011-10-25 22:07:23]

Ok, took care of the comments.  Now I just need to coordinate with Anton to
figure out how to check this in.

http://codereview.chromium.org/8380020/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8380020/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:229: intptr_t* used);
On 2011/10/25 21:50:53, Ivan Posva wrote:
> Not sure if it makes it easier to use this way:
> 
> Dart_Handle Dart_StringGet8(Dart_Handle str, uint8_t* codepoints, intptr_t*
> length);
> 
> var used = length;
> result = Dart_StringGet8(str, buffer, &used);

Yeah, I debated that.  Changed.

http://codereview.chromium.org/8380020/diff/1/runtime/include/dart_api.h#newc...
runtime/include/dart_api.h:264: DART_EXPORT Dart_Handle
Dart_ClosureSmrck(Dart_Handle object);
On 2011/10/25 21:50:53, Ivan Posva wrote:
> This does not match the result type in dart_api_impl.cc.

Fixed.

http://codereview.chromium.org/8380020/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8380020/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:785: "Object is not a String");
On 2011/10/25 21:50:53, Ivan Posva wrote:
> Weird alignment here and similar places.

Fixed.