Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: runtime/bin/process.cc

Issue 8380020: Refactor the dart api a bit: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/bin/process_script.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.cc
===================================================================
--- runtime/bin/process.cc (revision 775)
+++ runtime/bin/process.cc (working copy)
@@ -32,14 +32,13 @@
// The arguments are copied into a non-extensible array in the
// dart code so this should not fail.
ASSERT(Dart_IsArray(arguments));
- Dart_Result result = Dart_GetLength(arguments);
- ASSERT(Dart_IsValidResult(result));
- intptr_t length = Dart_GetResultAsCIntptr(result);
+ intptr_t length = 0;
+ Dart_Handle result = Dart_GetLength(arguments, &length);
+ ASSERT(Dart_IsValid(result));
char** string_args = new char*[length];
for (int i = 0; i < length; i++) {
- result = Dart_ArrayGetAt(arguments, i);
- ASSERT(Dart_IsValidResult(result));
- Dart_Handle arg = Dart_GetResult(result);
+ Dart_Handle arg = Dart_ArrayGetAt(arguments, i);
+ ASSERT(Dart_IsValid(arg));
// The Dart code verifies that the arguments implement the String
// interface. However, only builtin Strings are handled by
// GetStringValue.
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/bin/process_script.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698