Issue 8359023: Deserialize string data directly into a newly allocated object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8359023: Deserialize string data directly into a newly allocated object. (Closed)

Created:
9 years, 2 months ago by cshapiro

Modified:
9 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Deserialize string data directly into a newly allocated object. BUG=5283593 Committed: https://code.google.com/p/dart/source/detail?r=619

Patch Set 1 #

Total comments: 4

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -29 lines)			Patch
	M	runtime/vm/raw_object_snapshot.cc	View		3 chunks	+14 lines, -29 lines	4 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

siva

9 years, 2 months ago (2011-10-21 20:40:55 UTC) #2

LGTM

http://codereview.chromium.org/8359023/diff/1/runtime/vm/raw_object_snapshot.cc
File runtime/vm/raw_object_snapshot.cc (right):

http://codereview.chromium.org/8359023/diff/1/runtime/vm/raw_object_snapshot....
runtime/vm/raw_object_snapshot.cc:1006: *str_obj.CharAddr(i) =
reader->Read<uint8_t>();
*(str_obj.CharAddr(i)) = reader->Read<uint8_t>();

would be more readable?
ignore the comment if you think it is not.

http://codereview.chromium.org/8359023/diff/1/runtime/vm/raw_object_snapshot....
runtime/vm/raw_object_snapshot.cc:1053: for (int i = 0; i < len; i++) {
int => intptr_t like above?

http://codereview.chromium.org/8359023/diff/1/runtime/vm/raw_object_snapshot....
runtime/vm/raw_object_snapshot.cc:1054: *str_obj.CharAddr(i) =
reader->Read<uint16_t>();
ditto.

http://codereview.chromium.org/8359023/diff/1/runtime/vm/raw_object_snapshot....
runtime/vm/raw_object_snapshot.cc:1102: *str_obj.CharAddr(i) =
reader->Read<uint32_t>();
ditto.

Expand Messages | Collapse Messages