Deserialize string data directly into a newly allocated object.

runtime/vm/raw_object_snapshot.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bigint_operations.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/snapshot.h"
 #include "vm/visitor.h"
 
@@ skipping 981 matching lines @@
 
 RawOneByteString* OneByteString::ReadFrom(SnapshotReader* reader,
                                           intptr_t object_id,
                                           bool classes_serialized) {
   ASSERT(reader != NULL);
   // Read the length so that we can determine instance size to allocate.
   RawSmi* smi_len = GetSmi(reader->Read<intptr_t>());
   intptr_t len = Smi::Value(smi_len);
   RawSmi* smi_hash = GetSmi(reader->Read<intptr_t>());
 
-  // Allocate a one byte character area.
-  uint8_t* chars = new uint8_t[len];
-  for (int i = 0; i < len; i++) {
-    chars[i] = reader->Read<uint8_t>();
+  // Set up the one byte string object.
+  OneByteString& str_obj = OneByteString::ZoneHandle(
+      OneByteString::New(len, classes_serialized ? Heap::kOld : Heap::kNew));
+  for (intptr_t i = 0; i < len; i++) {
+    *str_obj.CharAddr(i) = reader->Read<uint8_t>();

[siva, 2011/10/21 20:40:55]

*(str_obj.CharAddr(i)) = reader->Read<uint8_t>();

would be more readable?
ignore the comment if you think it is not.

   }
 
-  // Set up the one byte string object.
-  OneByteString& str_obj = OneByteString::ZoneHandle(
-      OneByteString::New(chars,
-                         len,
-                         classes_serialized ? Heap::kOld : Heap::kNew));
-  delete[] chars;
   reader->AddBackwardReference(object_id, &str_obj);
   RawOneByteString* raw_str = str_obj.raw();
   raw_str->ptr()->hash_ = smi_hash;
   return str_obj.raw();
 }
 
 
 void RawOneByteString::WriteTo(SnapshotWriter* writer,
                                intptr_t object_id,
                                bool serialize_classes) {
@@ skipping 21 matching lines @@
 
 RawTwoByteString* TwoByteString::ReadFrom(SnapshotReader* reader,
                                           intptr_t object_id,
                                           bool classes_serialized) {
   ASSERT(reader != NULL);
   // Read the length so that we can determine instance size to allocate.
   RawSmi* smi_len = GetSmi(reader->Read<intptr_t>());
   intptr_t len = Smi::Value(smi_len);
   RawSmi* smi_hash = GetSmi(reader->Read<intptr_t>());
 
-  // Allocate a two byte character area.
-  uint16_t* chars = new uint16_t[len];
+  // Set up the two byte string object.
+  TwoByteString& str_obj = TwoByteString::ZoneHandle(
+      TwoByteString::New(len, classes_serialized ? Heap::kOld : Heap::kNew));
   for (int i = 0; i < len; i++) {

[siva, 2011/10/21 20:40:55]

int => intptr_t like above?

-    chars[i] = reader->Read<uint16_t>();
+    *str_obj.CharAddr(i) = reader->Read<uint16_t>();

[siva, 2011/10/21 20:40:55]

ditto.

   }
 
-  // Set up the two byte string object.
-  TwoByteString& str_obj = TwoByteString::ZoneHandle(
-      TwoByteString::New(chars,
-                         len,
-                         classes_serialized ? Heap::kOld : Heap::kNew));
-  delete[] chars;
   reader->AddBackwardReference(object_id, &str_obj);
   RawTwoByteString* raw_str = str_obj.raw();
   raw_str->ptr()->hash_ = smi_hash;
   return str_obj.raw();
 }
 
 
 void RawTwoByteString::WriteTo(SnapshotWriter* writer,
                                intptr_t object_id,
                                bool serialize_classes) {
@@ skipping 21 matching lines @@
 
 RawFourByteString* FourByteString::ReadFrom(SnapshotReader* reader,
                                             intptr_t object_id,
                                             bool classes_serialized) {
   ASSERT(reader != NULL);
   // Read the length so that we can determine instance size to allocate.
   RawSmi* smi_len = GetSmi(reader->Read<intptr_t>());
   intptr_t len = Smi::Value(smi_len);
   RawSmi* smi_hash = GetSmi(reader->Read<intptr_t>());
 
-  // Allocate a four byte character area.
-  uint32_t* chars = new uint32_t[len];
-  for (int i = 0; i < len; i++) {
-    chars[i] = reader->Read<uint32_t>();
+  // Set up the four byte string object.
+  FourByteString& str_obj = FourByteString::ZoneHandle(
+      FourByteString::New(len, classes_serialized ? Heap::kOld : Heap::kNew));
+  for (intptr_t i = 0; i < len; i++) {
+    *str_obj.CharAddr(i) = reader->Read<uint32_t>();

[siva, 2011/10/21 20:40:55]

ditto.

   }
 
-  // Set up the four byte string object.
-  FourByteString& str_obj = FourByteString::ZoneHandle(
-      FourByteString::New(chars,
-                         len,
-                         classes_serialized ? Heap::kOld : Heap::kNew));
-  delete[] chars;
   reader->AddBackwardReference(object_id, &str_obj);
   RawFourByteString* raw_str = str_obj.raw();
   raw_str->ptr()->hash_ = smi_hash;
   return str_obj.raw();
 }
 
 
 void RawFourByteString::WriteTo(SnapshotWriter* writer,
                                 intptr_t object_id,
                                 bool serialize_classes) {
@@ skipping 207 matching lines @@
   // Write out all the other fields.
   writer->Write<RawObject*>(ptr()->num_bracket_expressions_);
   writer->WriteObject(ptr()->pattern_);
   writer->Write<intptr_t>(ptr()->type_);
   writer->Write<intptr_t>(ptr()->flags_);
 
   // Do not write out the data part which is native.
 }
 
 }  // namespace dart